Skip to content

codex: use ThreadStore history for core review forks#20577

Draft
wiltzius-openai wants to merge 1 commit intowiltzius/codex/thread-store-app-server-migrationfrom
wiltzius/codex/thread-store-migration-stack
Draft

codex: use ThreadStore history for core review forks#20577
wiltzius-openai wants to merge 1 commit intowiltzius/codex/thread-store-app-server-migrationfrom
wiltzius/codex/thread-store-migration-stack

Conversation

@wiltzius-openai
Copy link
Copy Markdown
Contributor

@wiltzius-openai wiltzius-openai commented May 1, 2026

Why

After app-server no longer depends on rollout paths for thread-identity history reads, the remaining loaded-thread review/fork paths in core should use the same store-backed history boundary. This keeps direct rollout parsing in local-store compatibility code while allowing remote stores to provide history without filesystem access.

What changed

  • fork loaded parent threads from ThreadStore history in core agent control paths
  • migrate guardian review fork history to loaded session history instead of rereading rollout files
  • keep explicit rollout-path compatibility fallbacks outside the loaded-thread path

Verification

  • cargo test -p codex-core spawn_agent_fork

Bojun-Vvibe added a commit to Bojun-Vvibe/oss-contributions that referenced this pull request May 1, 2026
- anomalyco/opencode#25255: doom loop scope+filter-order fix (merge-as-is)
- openai/codex#20577: store-history fork migration (merge-after-nits)
- openai/codex#20528: skill-scoped hooks feature (merge-after-nits)
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-migration-stack branch from 5f7faf8 to 1da0d76 Compare May 1, 2026 15:27
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch 2 times, most recently from 7b8b9ab to 3dda86b Compare May 1, 2026 17:09
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-migration-stack branch from 1da0d76 to 3474484 Compare May 1, 2026 17:09
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch from 3dda86b to 0ab9b96 Compare May 1, 2026 17:15
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-migration-stack branch from 3474484 to 1b79226 Compare May 1, 2026 17:15
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch from 0ab9b96 to 34ea251 Compare May 1, 2026 18:11
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-migration-stack branch from 1b79226 to cfa324f Compare May 1, 2026 18:11
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch from 34ea251 to a645067 Compare May 1, 2026 18:47
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-migration-stack branch 2 times, most recently from de41539 to e18d4cb Compare May 1, 2026 19:55
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch from a645067 to d64ec1e Compare May 1, 2026 19:55
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-migration-stack branch from e18d4cb to fbfd2b9 Compare May 1, 2026 20:05
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch from d64ec1e to 4f8e5ae Compare May 1, 2026 20:05
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-migration-stack branch 2 times, most recently from fbfd2b9 to 6b96710 Compare May 1, 2026 21:05
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch from 4f8e5ae to 9baeb0e Compare May 1, 2026 21:05
@wiltzius-openai wiltzius-openai changed the title codex: use store history for core review forks codex: use ThreadStore history for core review forks May 1, 2026
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-migration-stack branch from 6b96710 to 8427230 Compare May 1, 2026 21:23
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch 2 times, most recently from 9449f34 to 03da85a Compare May 1, 2026 21:32
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-migration-stack branch from 8427230 to 3243fd6 Compare May 1, 2026 21:32
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch from 03da85a to a231ef7 Compare May 1, 2026 21:50
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-migration-stack branch from 3243fd6 to 3bc194d Compare May 1, 2026 21:50
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch from a231ef7 to ec5e41f Compare May 1, 2026 22:02
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-migration-stack branch from 3bc194d to 96a42fc Compare May 1, 2026 22:02
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch from ec5e41f to c29f912 Compare May 1, 2026 22:07
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-migration-stack branch from 96a42fc to dcb713c Compare May 1, 2026 22:07
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch from c29f912 to 03fc03f Compare May 1, 2026 22:29
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-migration-stack branch from dcb713c to 79c7d80 Compare May 1, 2026 22:29
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch from 03fc03f to df8dd3a Compare May 1, 2026 23:44
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-migration-stack branch from 79c7d80 to d9ed02c Compare May 1, 2026 23:45
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch from df8dd3a to d63d2d8 Compare May 1, 2026 23:51
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-migration-stack branch from d9ed02c to be8ad4e Compare May 1, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant