[core] Expose rollout-history turn boundaries#28462
Draft
adamvy-oai wants to merge 3 commits into
Draft
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
This was referenced Jun 16, 2026
4ac9c7c to
fb990e8
Compare
58d7e6e to
8c381af
Compare
fb990e8 to
48321c1
Compare
8c381af to
eaab9df
Compare
48321c1 to
7a32119
Compare
eaab9df to
8a1326d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This is the fourth change in a five-PR stack that improves reusable Rust APIs around the in-process app server and stored rollout history. It moves user-turn boundary classification out of context-manager internals so other history consumers can apply the same rule.
What
codex_core::rollout_historyis_user_turn_boundary()for persisted response itemsWhy
User-turn boundary classification describes persisted rollout history, but its implementation previously lived inside the context manager. Consumers reconstructing stored history should not depend on a context-manager implementation detail to apply the same classification.
Keeping the helper in
codex-corealso avoids moving contextual-fragment knowledge intocodex-rollout, which would require a broader dependency change.Stack
Each PR is based on the preceding branch:
Validation
Validation for the final stacked commits:
codex-corerollout-history testsjust test -p codex-app-server: 886 passed; one timing retry passed on its second attemptjust test -p codex-core: 2,717 passed; eight timing-sensitive failures passed in focused reruns, while five high-output code-mode failures remainedjust test --test-threads=8: 10,944 of 10,958 passed; the remaining failures were the same five high-output tests, three timing-sensitive tests that pass in focused reruns, and six tests in untouched exec/TUI code affected by this host's managed permission policyupstream/maincommitjust fix -p codex-app-server,just fix -p codex-core, andjust fmt; final worktree clean