[codex] Add generated token auth to app-server WebSockets#30315
Draft
mikhail-oai wants to merge 1 commit into
Draft
[codex] Add generated token auth to app-server WebSockets#30315mikhail-oai wants to merge 1 commit into
mikhail-oai wants to merge 1 commit into
Conversation
This was referenced Jun 27, 2026
This was referenced Jun 30, 2026
9dbf7fb to
ff76077
Compare
a4e08f8 to
d46eb76
Compare
|
The current head is the right shape: the generated query token is now connection authority, not only a startup hint. I would keep the draft gate on five invariants:
That gives a clean acceptance contract for moving the PR out of draft: connection established, degraded, or rejected is always explainable from one authority mode and one auditable reason. Boundary: implementation-review feedback only; no claim about running this branch, validating OpenAI, validating Codex, implementation correctness, production readiness, security review, partnership, customer interest, official alignment, conformance certification, or Neura usage. |
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QueryToken { token, enforce }as the default app-server WebSocket authentication modeQueryTokenis selectedtokenquery parameter by default--no-token-check, which keepsQueryTokenselected but disables enforcementMotivation
Loopback app-server WebSocket listeners previously accepted connections without a per-process secret. A generated capability in the connection URL prevents unrelated local clients from connecting by default while keeping startup and client configuration simple.
User impact
Starting
codex app-server --listen ws://127.0.0.1:4500usesQueryTokenmode and prints a URL such as:Clients must use that URL unless
--no-token-checkis set. When explicit--ws-auth capability-tokenor--ws-auth signed-bearer-tokenis configured, app-server prints the original token-free listen URL and enforces the selected bearer authentication mode.Warning on connections accepted without a valid query token is intentionally deferred.
Validation
just test -p codex-app-server-transport transport::auth::tests(16 tests)just test -p codex-app-server websocket_transport_no_token_check_accepts_invalid_tokensjust fix -p codex-app-server-transport -p codex-app-serverjust fmt