Skip to content

[codex-rs] Add writes app approval mode#30482

Open
zamoshchin-openai wants to merge 1 commit into
mainfrom
dev/alexz/apps-approval-mode-writes
Open

[codex-rs] Add writes app approval mode#30482
zamoshchin-openai wants to merge 1 commit into
mainfrom
dev/alexz/apps-approval-mode-writes

Conversation

@zamoshchin-openai

@zamoshchin-openai zamoshchin-openai commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds writes to AppToolApproval and exposes it through config and app-server schemas, including [apps._default].default_tools_approval_mode.
  • In writes, tools with readOnlyHint = true skip approval; all other tools prompt, including non-destructive writes and tools without annotations.
  • Prevents session or persistent approval choices in this mode so later writes still prompt.

Why

auto only prompts for risk-hinted actions, while prompt also interrupts reads. Apps need a middle mode that gates writes without prompting for declared read-only actions.

Validation

  • just write-config-schema
  • just write-app-server-schema
  • just fmt
  • just test -p codex-core mcp_turn_metadata (4 passed)
  • just test -p codex-core writes_mode (2 passed)
  • just test -p codex-app-server config_read_includes_apps (1 passed)
  • just test -p codex-app-server-protocol (251 passed)
  • just test -p codex-config (200 passed)
  • just test -p codex-cli (300 passed)
  • just fix -p codex-core -p codex-config -p codex-app-server-protocol -p codex-app-server -p codex-cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant