Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
currentTime/readhas a fixed total request budget, but the wait to enqueue its outbound request on the shared channel was outside that budget. Under backpressure, the app server could dispatch the request after the caller's deadline, leading to late work and misleading timeout behavior. Increasing the timeout would only mask the queue contention.This change makes the deadline behavior deterministic while we continue investigating the broader queue and instrumentation design. The structured timing work in #30334 remains the foundation for that follow-up.
What changed
currentTime/readnow uses that path, so its 10-second budget covers the outbound queue.Testing
just test -p codex-app-server deadline_expires_while_waiting_for_outgoing_queue_capacityjust fix -p codex-app-serverThe broader app-server suite was also attempted, but unrelated sandbox-dependent tests cannot run in this environment because macOS Seatbelt operations fail with
sandbox_apply: Operation not permitted.