fix: await voice STT cleanup tasks#3688
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asyncio.gather(..., return_exceptions=True).close()waits for cancelled background task finalizers.Why
OpenAISTTTranscriptionSession.close()previously cancelled listener, event processor, audio stream, and connection tasks without awaiting them. That could leave background exceptions and cleanup finalizers unobserved, especially around websocket shutdown. While validating the fix, the existing error-event path also exposed a race where_process_events_taskcan be created while_connection_taskis unwinding; the cleanup loop now catches that too.Tests
uv run --extra voice pytest tests/voice/test_openai_stt.py::test_close_awaits_cancelled_background_tasksuv run --extra voice pytest -vv tests/voice/test_openai_stt.py::test_session_error_eventuv run --extra voice pytest tests/voice/test_openai_stt.pyuv run ruff check src/agents/voice/models/openai_stt.py tests/voice/test_openai_stt.py