Repository navigation
ci: validate next pull requests and merge queue commits - #4149
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom codeEvaluated next: Trusted main policy: ✅ No new custom-code files detected. 48 mixed files remain; 0 existing customizations changed. Compared 48 existing customizations unchanged
8 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 39697473443 --repo openai/openai-python \
--name castiron-custom-code-39697473443-1 --dir /tmp/castiron-custom-code-39697473443-1
git apply --stat /tmp/castiron-custom-code-39697473443-1/custom-code.patch
cat /tmp/castiron-custom-code-39697473443-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin e1275d2b7636e52cd0a25f0e4e7185f0b3924ec7 a50acee8e5adf046fdd0c637527be6f7406b7e1c
python3 scripts/castiron/custom_code_report.py report \
--base e1275d2b7636e52cd0a25f0e4e7185f0b3924ec7 \
--head a50acee8e5adf046fdd0c637527be6f7406b7e1c --target-branch next --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-a50acee8e5ad
cat /tmp/castiron-custom-code-a50acee8e5ad/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a36ab344b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 20c96d0660
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Source-only static review of a50acee8e5adf046fdd0c637527be6f7406b7e1c: no actionable findings. The workflow runs the required jobs for next-branch pull requests and merge groups. The aggregate rejects failed, cancelled, skipped, and missing results; separate runtime jobs retain both Python versions. The next-specific check name and edited event handle retargeting without accepting another branch's skipped check.
The support-policy checks and current hosted CI passed or were skipped. I inspected the authored tests but did not execute candidate code or tests locally. Queue settings remain held until this workflow lands and the required real checks and CODEOWNER review are confirmed.
3 participants
The next branch has no CI trigger for merge-queue commits, and same-repository pull requests skip the runtime jobs. This runs lint, build, Python 3.10/3.14, HTTPX2, and support-policy checks for next pull requests and merge groups.
Adds a single
ci-requiredcheck that fails when any required job fails, is cancelled, is skipped, or has no result. Python 3.10 and 3.14 use independent jobs so selective reruns cannot hide a failed sibling. Intentional metadata-only push exclusions remain intact. Legacy artifact staging and OIDC upload are restricted to main pushes, preventing candidate builds from reaching the privileged upload path. Existing action pins and credential settings remain unchanged.Branch settings will be configured only after this workflow lands and its real checks pass.
Validation: actionlint passed; actual aggregate shell passed 25 success/failure/cancellation/skip/missing-result scenarios; both concrete runtime jobs preserve the prior matrix-child steps exactly; basic diff review and git diff --check passed. Hosted validation pending.