Skip to content

chore(api): clarify service-account API key deletion - #4151

Merged
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-318
Oct 22, 2026
Merged

jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-318

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Summary

Clarifies that authorized callers can delete individual service-account API keys.

Changes

  • Document that deleting a service-account key preserves the account and its other keys.
  • Remove the obsolete second-key conflict from the API reference.

Castiron-Internal-PR: openai/openai-python-internal#318
Castiron-Source-SHA: 36b987de3798d5c6534a94011995bd3cf5a353b2
Castiron-Public-Base-SHA: 7cd7028
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 22, 2026 02:51
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T02:52:57.186053Z d357f11 PR opened
🔒 Security Review ✅ Completed 2026-10-22T02:53:45.875442Z d357f11 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Castiron custom code

Evaluated main: 7cd702895379656bee62047ff64813ff616aeef7.

Trusted main policy: 7cd702895379656bee62047ff64813ff616aeef7.

Mixed files: 46 → 48

2 newly customized · 0 customizations removed · 0 existing customizations changed · 11 generated baselines changed

Compared 7cd702895379 → d357f11559b4. Generated baselines verified.

File Result Current custom patch
scripts/castiron/custom_code_budget.py Generated baseline changed +41 / −20
scripts/castiron/custom_code_report.py Generated baseline changed +189 / −17
scripts/castiron/test_custom_code_report.py Generated baseline changed +621 / −0
src/openai/resources/beta/responses/responses.py Generated baseline changed +122 / −92
src/openai/resources/live/forks.py Generated baseline changed +85 / −56
src/openai/resources/live/live.py Generated baseline changed +81 / −44
src/openai/resources/live/sideband.py Generated baseline changed +89 / −70
src/openai/resources/realtime/realtime.py Generated baseline changed +80 / −54
src/openai/resources/realtime/translations/translations.py Generated baseline changed +98 / −40
src/openai/resources/responses/responses.py Generated baseline changed +986 / −110
src/openai/types/init.py Generated baseline changed +1 / −0
37 existing customizations unchanged
  • api.md
  • scripts/castiron/fixtures/github_publisher.cjs
  • scripts/castiron/test_custom_code_budget.py
  • scripts/castiron/test_custom_code_github.py
  • scripts/castiron/test_custom_code_publication.py
  • src/openai/init.py
  • src/openai/_client.py
  • src/openai/resources/audio/transcriptions.py
  • src/openai/resources/audio/translations.py
  • src/openai/resources/beta/agents/environments/files.py
  • src/openai/resources/beta/agents/sessions/artifacts.py
  • src/openai/resources/beta/agents/sessions/sessions.py
  • src/openai/resources/beta/beta.py
  • src/openai/resources/beta/threads/runs/runs.py
  • src/openai/resources/beta/threads/threads.py
  • src/openai/resources/chat/completions/completions.py
  • src/openai/resources/embeddings.py
  • src/openai/resources/files.py
  • src/openai/resources/realtime/api.md
  • src/openai/resources/uploads/uploads.py
  • src/openai/resources/vector_stores/file_batches.py
  • src/openai/resources/vector_stores/files.py
  • src/openai/resources/videos.py
  • src/openai/resources/webhooks/init.py
  • src/openai/resources/webhooks/webhooks.py
  • src/openai/types/decision_input_image_param.py
  • src/openai/types/decision_input_text_param.py
  • src/openai/types/fine_tuning/fine_tuning_job_integration.py
  • src/openai/types/realtime/conversation_item_input_audio_transcription_delta_event.py
  • src/openai/types/realtime/realtime_error_event.py
  • src/openai/types/responses/tool.py
  • src/openai/types/responses/tool_param.py
  • src/openai/types/webhooks/init.py
  • src/openai/types/webhooks/live_call_incoming_webhook_event.py
  • src/openai/types/webhooks/unwrap_webhook_event.py
  • tests/api_resources/admin/organization/projects/test_api_keys.py
  • tests/api_resources/test_videos.py

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 39713724511 --repo openai/openai-python \
  --name castiron-custom-code-39713724511-1 --dir /tmp/castiron-custom-code-39713724511-1
git apply --stat /tmp/castiron-custom-code-39713724511-1/custom-code.patch
cat /tmp/castiron-custom-code-39713724511-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 7cd702895379656bee62047ff64813ff616aeef7 d357f11559b41603b05d7776f51bdeb7f67f1484
python3 scripts/castiron/custom_code_report.py report \
  --base 7cd702895379656bee62047ff64813ff616aeef7 \
  --head d357f11559b41603b05d7776f51bdeb7f67f1484 --target-branch main --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-d357f11559b4
cat /tmp/castiron-custom-code-d357f11559b4/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 6ed945e Oct 22, 2026
32 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the castiron/promotions/pr-318 branch October 22, 2026 03:14
@openai-sdks openai-sdks Bot mentioned this pull request Oct 22, 2026
gh-actions-shared Bot pushed a commit to xf-qubit/openai-python that referenced this pull request Oct 22, 2026
Automated Release PR
---


##
[3.36.1](openai/openai-python@v3.36.0...v3.36.1)
(2026-10-22)


### Bug Fixes

* **api:** honor per-call WebSocket query settings
([openai#4138](openai#4138))
([d40a5e1](openai@d40a5e1))
* **examples:** stop microphone capture between recordings
([openai#4143](openai#4143))
([26e5d92](openai@26e5d92))
* validate browser calls before reading driver state
([openai#4142](openai#4142))
([2bfe460](openai@2bfe460))


### Chores

* **api:** clarify service-account API key deletion
([openai#4151](openai#4151))
([6ed945e](openai@6ed945e))


### Refactors

* prepare handwritten chunked upload runtime
([openai#4146](openai#4146))
([2d58e82](openai@2d58e82))
* prepare handwritten vector-store polling runtime
([openai#4148](openai#4148))
([7cd7028](openai@7cd7028))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants