Conversation
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta name="viewport" content="initial-scale=1.0, minimum-scale=1.0" /> | ||
| <meta name="theme-color" content="#375f7E" /> |
There was a problem hiding this comment.
why the removal? I thought this does something shiny in Safari
There was a problem hiding this comment.
Ah okay, can you remember what? 🤔 I thought I remove it because it's not widely supported by browsers and #375f7e looks like a random color that's not related to any of our colors.
There was a problem hiding this comment.
ok 👍 no idea where it's even visible in Safari. Ok, kill it then.
|
i recall the date picker also had some colorScheme setting based on isDark. i think this pr will cover that too |
|
web/packages/design-system/src/components/OcDatepicker/OcDatepicker.vue Lines 123 to 130 in 554dc22 this is it. but im not sure what filter: invert(0) does and what happens if its removed? |
Sets the current theme via the `color-scheme` CSS prop, ensuring that native browser elements like scroll bars have the proper color.
JammingBen
force-pushed
the
feat/global-css-color-scheme
branch
from
bce0842 to
84af22f
Compare
|
Thanks for the hint! This is obsolete now. |
feat: set global color-scheme
4 participants
Sets the current theme via the
color-schemeCSS prop, ensuring that native browser elements like scroll bars have the proper color.closes #2123