SAI support for Credit Based Flow Control as defined in UEC 1.0.#2263
SAI support for Credit Based Flow Control as defined in UEC 1.0.#2263rck-innovium wants to merge 1 commit intoopencomputeproject:masterfrom
Conversation
JaiOCP
left a comment
JaiOCP
left a comment
There was a problem hiding this comment.
Please add the markdown file as well with work flow etc.
| SAI_PORT_ATTR_QOS_DOT1P_DEI_TO_TC_MAP, | ||
|
|
||
| /** | ||
| * @brief List of virtual channels for the port. |
There was a problem hiding this comment.
Virtual channels are essentially traffic class
|
|
||
| /** Virtual Channel */ | ||
| sai_uint8_t vc; | ||
|
|
There was a problem hiding this comment.
This is changing the struct size. What are the warm boot implications of it.
There was a problem hiding this comment.
good question, since this is breaking change, also serialize/deserialize in sairedis would need to handle this case
There was a problem hiding this comment.
If we can do the serialize/deserialize in sairedis for this size change, it would be good.
There is no cleaner way to get around this. If we really dont want to change the size of this struct, we can take the below approach which could be potentially confusing for the application writers:
-
Overloading the existing dot1p to be used as dot1p_dei when the qosmap type is SAI_QOS_MAP_TYPE_DOT1P_DEI_TO_TC.
-
Similarly, overload the existing fc to be used as vc when the qosmap type is SAI_QOS_MAP_TYPE_QUEUE_TO_VC or SAI_QOS_MAP_TYPE_TC_TO_VC.
Please give your suggestions.
There was a problem hiding this comment.
looks like a good topic for sai community meeting, handling serialization is easy
Added [doc/CBFC/SAI-Credit_Based_Flow_Control.md] |
Signed-off-by: rck-innovium <rck@marvell.com>
|
/azp run |
|
Commenter does not have sufficient privileges for PR 2263 in repo opencomputeproject/SAI |
4 participants
SAI support for Credit Based Flow Control as defined in UEC 1.0 on behalf of UEC Manageability Work Group.
Note: Reviewers who are non UEC members must follow the instructions #2226