ci: publish to maven central without the portal click - #681
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AHuzgqeyTCZgudXffVR45c
The vanniktech plugin validates the deployment on the automatic path, so the polling script is no longer needed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AHuzgqeyTCZgudXffVR45c
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88d7ccbad3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The release status reports a version as published from these jobs' exit codes, and validation passing is no promise that publishing did. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AHuzgqeyTCZgudXffVR45c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both Central uploads parked a deployment in the Sonatype portal and waited for
someone to press release. That step gets forgotten — v6.3.0 and v6.4.0 both sat
unpublished — and nobody inspects the deployment while it waits, so it buys
nothing.
jni/pom.xml:autoPublish=truein thecentralprofile. The plugin'swaitUntildefault isvalidated, so a bundle the portal rejects still failsthe build instead of being published.
android/build.gradle.kts:publishToMavenCentral(true, VALIDATED). With theautomatic path on, the plugin waits for the portal's verdict itself, which is
what
.github/scripts/await-central-validation.shwas doing by hand — scriptand its workflow step are gone, along with the
tee/pipefailplumbing thatfed it.
Verified
-Pcentralresolves toautoPublish=trueviahelp:effective-pom,and that the android publishing tasks still configure. The real check is the
next release.