Skip to content

revert: don't allow publishing within a draft change log context#574

Merged
ormsbee merged 1 commit intomainfrom
braden/revert-validation
Apr 30, 2026
Merged

revert: don't allow publishing within a draft change log context#574
ormsbee merged 1 commit intomainfrom
braden/revert-validation

Conversation

@bradenmacdonald
Copy link
Copy Markdown
Contributor

This reverts a change from #521 as it turns out that the only place in openedx-platform where we're using bulk_draft_changes_for to group changes together is also publishing changes within that bulk context. So the change to disallow that is causing test failures, and in order to resolve it quickly for Verawood, we may revert this additional validation for now.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 30, 2026
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @bradenmacdonald!

This repository is currently maintained by @axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Apr 30, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Apr 30, 2026
@ormsbee ormsbee merged commit 560e231 into main Apr 30, 2026
6 checks passed
@ormsbee ormsbee deleted the braden/revert-validation branch April 30, 2026 03:57
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants