Skip to content

fix: prevent .modal-fullscreen cascading flex boxes #38431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
navinkarkera merged 3 commits into from
Apr 29, 2026
+25 −25
Merged

fix: prevent .modal-fullscreen cascading flex boxes #38431

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ffd6828
fix: prevent .modal-fullscreen cascading flex boxes
rpenido Apr 23, 2026
057ccf2
fix: fix fullscreen for word cloud and lti consumer
rpenido Apr 24, 2026
543fa51
chore: trigger ci
rpenido Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 25 additions & 25 deletions cms/static/sass/elements/_modal-window.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,43 +406,43 @@
display: flex;
flex-direction: column;


// Set the components to flex so that they can grow
div,
form {
div.edit-xblock-modal {
display: flex;
flex-direction: column;
flex-grow: 1;

// Set the header to not grow
header,
&.modal-header {
flex-grow: 0;
}
div.modal-content {
display: flex;
flex-direction: column;
flex-grow: 1;
padding: 0;

}
div.xblock-editor {
display: flex;
flex-direction: column;
flex-grow: 1;

ul {
flex-grow: 1;
div.xblock-studio_view {
display: flex;
flex-direction: column;
flex-grow: 1;
}

// Reset the divs inside the ul to preserve previous styling
div,
form {
display: unset;
flex-direction: unset;
flex-grow: unset;
}
}
div.editor-with-buttons {
display: flex;
flex-direction: column;
flex-grow: 1;
margin-bottom: 0;

&.modal-editor {
.modal-content {
padding: 0px;
ul.settings-list {
flex-grow: 1;
}
}
}
}
}
}



// specific modal overrides
// ------------------------

Expand Down
Loading