Skip to content

fix: guard get_enterprise_learner_portal when request has no user #38802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chessing234 wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −1
Open

fix: guard get_enterprise_learner_portal when request has no user #38802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions openedx/features/enterprise_support/tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,13 @@ def test_get_enterprise_learner_portal_no_enterprise_user(self):
portal = get_enterprise_learner_portal(request)
assert portal is None

@override_waffle_flag(ENTERPRISE_HEADER_LINKS, True)
def test_get_enterprise_learner_portal_request_without_user(self):
request = mock.MagicMock(spec=[])
request.session = {}
portal = get_enterprise_learner_portal(request)
assert portal is None

def test_get_enterprise_learner_generic_name_404_pages(self):
request = mock.Mock(view_name='404')
assert get_enterprise_learner_generic_name(request) is None
Expand Down
2 changes: 1 addition & 1 deletion openedx/features/enterprise_support/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ def get_enterprise_learner_portal(request):
# Prevent a circular import.
from openedx.features.enterprise_support.api import enterprise_customer_uuid_for_request, enterprise_enabled

user = request.user
user = getattr(request, 'user', None)
# Only cache this if a learner is authenticated (AnonymousUser exists and should not be tracked)

learner_portal_session_key = 'enterprise_learner_portal'
Expand Down