8374456: JVM crashes with "assert(resolved_method->method_holder()->is_linked()) failed: must be linked" when run with large value for PreallocatedOutOfMemoryErrorCount

[dholmes-ora]

Please review this trivial fix to add a range(0,1024) to the develop flag PreallocatedOutOfMemoryErrorCount to avoid absurdly large values from causing a crash. Anyone who needs an even larger value can easily change it directly.

Testing: manual (no regression test warranted)

Thanks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8374456: JVM crashes with "assert(resolved_method->method_holder()->is_linked()) failed: must be linked" when run with large value for PreallocatedOutOfMemoryErrorCount (Bug - P4)

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29027/head:pull/29027
$ git checkout pull/29027

Update a local copy of the PR:
$ git checkout pull/29027
$ git pull https://git.openjdk.org/jdk.git pull/29027/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29027

View PR using the GUI difftool:
$ git pr show -t 29027

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29027.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374456: JVM crashes with "assert(resolved_method->method_holder()->is_linked()) failed: must be linked" when run with large  value for PreallocatedOutOfMemoryErrorCount

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• eee5854: 8366058: Outdated comment in WinCAPISeedGenerator
• e676c9d: 8357258: x86: Improve receiver type profiling reliability
• 1630382: 8373704: Improve "SocketException: Protocol family unavailable" message

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dholmes-ora The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (77b2a6df)

[coleenp]

Looks good and trivial.

[dholmes-ora]

Thanks for the review @coleenp !

/integrate

[openjdk]

Going to push as commit de81d38.
Since your change was applied there have been 8 commits pushed to the master branch:

• fa8ea6b: 8374168: Resolve disabled warnings in JDWP agent
• 5fd095f: 8372591: assert(!current->cont_fastpath() || freeze.check_valid_fast_path()) failed
• 27dbdec: 8374217: Remove IO.java test from AOT ProblemList
• ... and 5 more: https://git.openjdk.org/jdk/compare/6eaabed55ca4670d8c317f0a4323ccea4dd0b9ca...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora Pushed as commit de81d38.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.