Skip to content

Fix the structure of Ps.93.4, by treating the Azla Legarmeh in the first word as a SHALISH - #108

Merged
jag3773 merged 1 commit into
openscriptures:masterfrom
noamraph:ps-93-4-structure-azla-legarmeh
Nov 11, 2026
Merged

jag3773 merged 1 commit into
openscriptures:masterfrom
noamraph:ps-93-4-structure-azla-legarmeh

Conversation

@noamraph

@noamraph noamraph commented May 4, 2025 •

Copy link
Copy Markdown
Contributor

(Note: this is following this message.)

Currently, this is the structure of Ps.93.4:
image
It doesn't make sense according to the meaning of the word. I fixed it so it looks like this:
image
This is very similar to Ps.93.3:
image

I think that the issue is that since Azla Legarmeh replaces Oleh VeYored when it comes at the first word in the verse, this was treated as an Oleh VeYored. However, from the actual meaning of the words, I think that it's clear that it should be treated as a regular Azla Legarmeh (Like in verse 3).

Is a change in the XML file how to fix this, or is the XML file autogenerated from another file?

If this is accepted, I guess that a next step would be to look for other Azla Legarmeh at the first word to see if they need to be fixed as well. I wonder if there's a way to automatically know if the Azla Legarmeh at the first word should be treated like an Oleh VeYored or not.

…rst word as a SHALISH, even though it's in the first word.
@jag3773 jag3773 assigned jdejoode and unassigned jdejoode May 6, 2025
@jag3773

jag3773 commented May 6, 2025

Copy link
Copy Markdown
Member

@jdejoode or @DavidTroidl Can you review this PR?

@0-Actual

Copy link
Copy Markdown

Agent: Gaucia — AI-assisted technical review for Sherman G. Laing / Quantum.Earth.Laing.

I checked PR head 4dce9f80036439b86ac403201bda54546591a969 against base 3d15126fb1ef74867fc1434be1942e837932691f and verified that the proposed patch changes only word ID 19AHF in Psalm 93:4, from n="2" to n="1.0.0". The word's text, lemma, morphology, ID, and the remaining XML content are preserved.

For the question about where to edit: the repository's structure/OshbVerse/Script/Structure.js loads the WLC book XML directly; ElementMarkup.js reads the n attributes, and the verse-layout code groups the resulting lines by those codes. The separate structure/write_wlc_chapters.py copies existing chapter XML rather than deriving these n values from accents. Thus this patch targets data consumed by the viewer. This source trace does not establish whether an external authoring process must also be updated.

That is a technical scope review, not approval of the proposed cantillation interpretation. The existing request for specialist review remains appropriate; I would not generalize a new automatic rule from this one verse.

Review: Sherman G. Laing / Quantum.Earth.Laing, with Gaucia. Proposed correction remains credited to noamraph.

@jag3773

jag3773 commented Nov 11, 2026

Copy link
Copy Markdown
Member

These review notes were prepared by Claude (an AI assistant) working at my direction. I'm posting them for the record; corrections are welcome.

Thank you for this, and apologies that it waited so long. With no cantillation specialist available to review, we checked it against the repository's own data and the standard references. The change looks right.

What the current value means. n="2" is the Oleh veYored level: 358 of the 362 Oleh veYored words in Psalms, Proverbs and the poetic part of Job carry it. Every verse in those books that begins with a plain Azla Legarmeh and has no Oleh veYored is coded 2, all 22 of them. That looks like a blanket rule applied mechanically, not a verse-by-verse decision.

What the references say.

  • Wickes (Poetical Books, p. 34), whom the OSHB cantillation page names as the basis for these divisions, does say that Azla Legarmeh stands in for Oleh veYored on the first word of a verse. But he lists where: the titles לְדָוִד (Pss 26, 27, 35, 37, 103, 138, 144) and לִשְׁלֹמֹה (Ps 72), and opening Hallelujahs. Psalm 93:4 is not on that list. (Caveat: this was read from the archive.org scan, whose OCR is poor, and not in full.)
  • Price (The Syntax of Masoretic Accents in the Hebrew Bible, ch. 13–14) says the Ole-WeYored segment "has no substitute segment", and cites Ps 93:4 by name among the Great Rebia clauses that have a preceding Legarmeh. That is the reading this PR gives.
  • Within the data, Ps 93:3 (נָשְׂא֤וּ נְהָר֨וֹת ׀ יְֽהוָ֗ה) is already coded 1.0.0, 1.0, 1, 0, the same shape this PR gives verse 4. Miqra according to the Masorah also keeps מִקֹּלוֹת ׀ מַיִם רַבִּים together on one poetic line.

Your question about the XML. Nothing in this repository generates the n values, and the structure viewer reads wlc/*.xml directly, so editing the XML is the right way to make this fix.

Follow-up, not blocking. Thirteen other verses carry the same 2 on a first-word Azla Legarmeh and are outside Wickes's list: Ps 32:8, 36:7, 38:12, 76:6, 81:11, 87:5, 91:4, 91:15, 93:5, 113:9, and Prov 6:14, 6:22, 30:15. Each needs its own look. In the other direction, most of the opening Hallelujahs that Wickes does list (Pss 111–113, 135, 148–150) are coded as ordinary breaks, because the WLC writes הַלְלוּ יָהּ as two words there.

Outcome: we intend to merge this. The website serves the gh-pages branch, so the structure viewer will show the change only after the site is next updated; that is being planned separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants