Skip to content

multus: Add tolerations to whereabouts-controller Deployment - #3107

Open
ssonigra wants to merge 1 commit into
openshift:masterfrom
ssonigra:patch-3
Open

multus: Add tolerations to whereabouts-controller Deployment#3107
ssonigra wants to merge 1 commit into
openshift:masterfrom
ssonigra:patch-3

Conversation

@ssonigra

@ssonigra ssonigra commented Aug 5, 2026

Copy link
Copy Markdown

Bug: https://redhat.atlassian.net/browse/OCPBUGS-77772

What

Adds operator: Exists toleration to the whereabouts-controller Deployment in bindata/network/multus/multus.yaml.

Why

The whereabouts-controller Deployment had no tolerations at all. When all worker nodes are tainted, the pod cannot be scheduled anywhere. This was discovered during testing of the whereabouts-reconciler toleration fix (#3105).

All other Multus DaemonSets already have operator: Exists tolerations.

How to verify

  1. Taint all worker nodes:
    oc adm taint nodes -l node-role.kubernetes.io/worker test-taint=true:NoExecute
    
  2. Verify the whereabouts-controller pod is running:
    oc get pods -n openshift-multus -o wide | grep whereabouts-controller
    

Related

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@ssonigra, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 3 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: e688096d-cdc7-428b-8e16-214f85653177

📥 Commits

Reviewing files that changed from the base of the PR and between d3ad345 and cdab7bf.

📒 Files selected for processing (1)
  • bindata/network/multus/multus.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from jcaamano and marty-power August 5, 2026 10:34
@ssonigra ssonigra changed the title Add tolerations to multus.yaml configuration multus: Fix whereabouts tolerations for tainted nodes Aug 5, 2026
@ssonigra ssonigra changed the title multus: Fix whereabouts tolerations for tainted nodes multus: Add tolerations to whereabouts-controller Deployment Aug 5, 2026
The whereabouts-controller Deployment had no tolerations, causing the
pod to not be scheduled when all worker nodes are tainted. Added
`operator: Exists` toleration to match all other Multus workloads.

Signed-off-by: Saurab Sonigra <ssonigra@redhat.com>
@rameshsahoo11

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-ovn-upgrade-ipsec

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn-fdp-qe
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-windows
/test e2e-azure-ovn-upgrade
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-dualstack-bgp
/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-ovn-ipv6-ipsec
/test e2e-ovn-ipsec-step-registry
/test hypershift-e2e-aks

@openshift-ci

openshift-ci Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rameshsahoo11, ssonigra
Once this PR has been reviewed and has the lgtm label, please assign tssurya for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ssonigra

ssonigra commented Aug 7, 2026

Copy link
Copy Markdown
Author

/assign tssurya

@ssonigra

ssonigra commented Aug 7, 2026

Copy link
Copy Markdown
Author

/retest

@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@ssonigra: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants