Skip to content

NO-ISSUE: Fix invalid JSON in daemon-config-lm-ovn.json perNodeCertificate block - #3110

Open
bpickard22 wants to merge 1 commit into
openshift:release-4.17from
bpickard22:4.17-lm-ovn-json-fix
Open

NO-ISSUE: Fix invalid JSON in daemon-config-lm-ovn.json perNodeCertificate block#3110
bpickard22 wants to merge 1 commit into
openshift:release-4.17from
bpickard22:4.17-lm-ovn-json-fix

Conversation

@bpickard22

Copy link
Copy Markdown
Contributor

Add missing }, closing the perNodeCertificate object in daemon-config-lm-ovn.json. Without this, the rendered JSON is invalid when NETWORK_NODE_IDENTITY_ENABLE is true.

Caught during review of #3040.

…cate block

Add missing closing brace and comma for the perNodeCertificate object,
caught during review of PR openshift#3040.

Assisted by Claude Opus 4.6

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Benjamin Pickard <bpickard@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 5, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@bpickard22: This pull request explicitly references no jira issue.

Details

In response to this:

Add missing }, closing the perNodeCertificate object in daemon-config-lm-ovn.json. Without this, the rendered JSON is invalid when NETWORK_NODE_IDENTITY_ENABLE is true.

Caught during review of #3040.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a2ee8a1b-fe0b-481e-be80-781a61a5d493

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@kyrtapz

kyrtapz commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 6, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-serial
/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-upgrade-ipsec
/test e2e-aws-ovn-windows
/test e2e-azure-ovn-upgrade
/test e2e-gcp-ovn
/test e2e-gcp-ovn-techpreview
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6

@openshift-ci

openshift-ci Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpickard22, kyrtapz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2026
@openshift-ci

openshift-ci Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@bpickard22: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 2d141cd link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bpickard22 bpickard22 changed the title NO-JIRA: Fix invalid JSON in daemon-config-lm-ovn.json perNodeCertificate block NO-ISSUE: Fix invalid JSON in daemon-config-lm-ovn.json perNodeCertificate block Aug 12, 2026
@bpickard22

Copy link
Copy Markdown
Contributor Author

/verified by me

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 12, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@bpickard22: This PR has been marked as verified by me.

Details

In response to this:

/verified by me

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bpickard22

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@bpickard22: This pull request explicitly references no jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bpickard22

Copy link
Copy Markdown
Contributor Author

/jira-refresh

@bpickard22

Copy link
Copy Markdown
Contributor Author

/tide refresh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants