NO-ISSUE: Fix invalid JSON in daemon-config-lm-ovn.json perNodeCertificate block - #3110
NO-ISSUE: Fix invalid JSON in daemon-config-lm-ovn.json perNodeCertificate block#3110bpickard22 wants to merge 1 commit into
Conversation
…cate block Add missing closing brace and comma for the perNodeCertificate object, caught during review of PR openshift#3040. Assisted by Claude Opus 4.6 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Benjamin Pickard <bpickard@redhat.com>
|
@bpickard22: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
/lgtm |
|
Scheduling required tests: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bpickard22, kyrtapz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@bpickard22: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by me |
|
@bpickard22: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@bpickard22: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira-refresh |
|
/tide refresh |
Add missing
},closing the perNodeCertificate object in daemon-config-lm-ovn.json. Without this, the rendered JSON is invalid when NETWORK_NODE_IDENTITY_ENABLE is true.Caught during review of #3040.