[release-4.21] OCPBUGS-113468: Remove unscoped CSV watch from ClusterNotUpgradeableAlert by rsacherer · Pull Request #17079 · openshift/console

rsacherer · 2026-08-24T12:12:26Z

This is a backport of #16904 to release-4.21 (via #17013 for release-4.22).

The ClusterNotUpgradeableAlert component fetched all ClusterServiceVersions cluster-wide (resulting in up to 600MB object sizes in the browser on clusters with 350+ namespaces and lots of operators) on every visit to Cluster Settings when Upgradeable=False was set.

The only use of CSVs was to decide whether or not to show navigation links.

For installed operators this was ineffective: CSV status.conditions use phase/reason fields, not type/status, so getConditionUpgradeableFalse() always returned undefined on CSVs — meaning notUpgradeableCSVsPresent was permanently false and the 'View installed Operators' link was never shown.

Additionally the link URL used /k8s/ns/all-namespaces/ instead of /k8s/all-namespaces/, causing 'No Operators found' on navigation.

Fix: remove both the ClusterOperator and CSV watches. Both navigation links are now always shown when the alert renders — correct since the alert only mounts when Upgradeable=False is already confirmed on ClusterVersion. Use resourceListPathFromModel() for the correct all-namespaces URL.

Backport note: On release-4.21 the ClusterNotUpgradeableAlert lives in cluster-settings.tsx (not cluster-settings-utils.tsx as in main) and uses SyncMarkdownView/removeQueryArgument (not MarkdownView/useQueryParamsMutator) due to refactoring between 4.21 and main. The fix is otherwise identical. Test fixtures updated for stricter UpdateHistory/ClusterVersionStatus types on 4.21, and jest.mock factories use React.createElement instead of JSX (older babel-plugin-jest-hoist constraint).

https://issues.redhat.com/browse/OCPBUGS-113468

openshift-merge-bot · 2026-08-24T12:12:28Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-08-24T12:12:32Z

@rsacherer: This pull request references Jira Issue OCPBUGS-113467, which is invalid:

expected Jira Issue OCPBUGS-113467 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a backport of #16904 to release-4.21 (via #17013 for release-4.22).

The ClusterNotUpgradeableAlert component fetched all ClusterServiceVersions cluster-wide (resulting in up to 600MB object sizes in the browser on clusters with 350+ namespaces and lots of operators) on every visit to Cluster Settings when Upgradeable=False was set.

The only use of CSVs was to decide whether or not to show navigation links.

For installed operators this was ineffective: CSV status.conditions use phase/reason fields, not type/status, so getConditionUpgradeableFalse() always returned undefined on CSVs — meaning notUpgradeableCSVsPresent was permanently false and the 'View installed Operators' link was never shown.

Additionally the link URL used /k8s/ns/all-namespaces/ instead of /k8s/all-namespaces/, causing 'No Operators found' on navigation.

Fix: remove both the ClusterOperator and CSV watches. Both navigation links are now always shown when the alert renders — correct since the alert only mounts when Upgradeable=False is already confirmed on ClusterVersion. Use resourceListPathFromModel() for the correct all-namespaces URL.

Backport note: On release-4.21 the ClusterNotUpgradeableAlert lives in cluster-settings.tsx (not cluster-settings-utils.tsx as in main) and uses SyncMarkdownView/removeQueryArgument (not MarkdownView/useQueryParamsMutator) due to refactoring between 4.21 and main. The fix is otherwise identical. Test fixtures updated for stricter UpdateHistory/ClusterVersionStatus types on 4.21, and jest.mock factories use React.createElement instead of JSX (older babel-plugin-jest-hoist constraint).

https://issues.redhat.com/browse/OCPBUGS-113467

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-08-24T12:12:33Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b30be26d-52dc-47f0-bb3f-776648e881c5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

…lert The ClusterNotUpgradeableAlert component fetched all ClusterServiceVersions cluster-wide (resulting in up to 600MB object sizes in the browser on clusters with 350+ namespaces and lots of operators) on every visit to Cluster Settings when Upgradeable=False was set. The only use of CSVs was to decide whether or not to show navigation links. For installed operators this was ineffective: CSV status.conditions use phase/reason fields, not type/status, so getConditionUpgradeableFalse() always returned undefined on CSVs — meaning notUpgradeableCSVsPresent was permanently false and the 'View installed Operators' link was never shown. Additionally the link URL used /k8s/ns/all-namespaces/ instead of /k8s/all-namespaces/, causing 'No Operators found' on navigation. Fix: remove both the ClusterOperator and CSV watches. Both navigation links are now always shown when the alert renders — correct since the alert only mounts when Upgradeable=False is already confirmed on ClusterVersion. Use resourceListPathFromModel() for the correct all-namespaces URL. Backport note: On release-4.21 the ClusterNotUpgradeableAlert lives in cluster-settings.tsx (not cluster-settings-utils.tsx as in main) and uses SyncMarkdownView/removeQueryArgument (not MarkdownView/useQueryParamsMutator) due to refactoring that happened between 4.21 and main. The fix is otherwise identical. Test fixtures updated for stricter UpdateHistory/ClusterVersionStatus types on 4.21. https://issues.redhat.com/browse/OCPBUGS-109521 Signed-off-by: Raimund Sacherer <switch1024@gmail.com>

openshift-ci · 2026-08-24T12:18:30Z

Hi @rsacherer. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

rsacherer · 2026-08-24T12:26:12Z

/jira refresh

openshift-ci-robot · 2026-08-24T12:26:16Z

@rsacherer: This pull request references Jira Issue OCPBUGS-113467, which is invalid:

expected Jira Issue OCPBUGS-113467 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-08-24T12:30:48Z

@rsacherer: This pull request references Jira Issue OCPBUGS-113468, which is invalid:

expected Jira Issue OCPBUGS-113468 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a backport of #16904 to release-4.21 (via #17013 for release-4.22).

The ClusterNotUpgradeableAlert component fetched all ClusterServiceVersions cluster-wide (resulting in up to 600MB object sizes in the browser on clusters with 350+ namespaces and lots of operators) on every visit to Cluster Settings when Upgradeable=False was set.

The only use of CSVs was to decide whether or not to show navigation links.

For installed operators this was ineffective: CSV status.conditions use phase/reason fields, not type/status, so getConditionUpgradeableFalse() always returned undefined on CSVs — meaning notUpgradeableCSVsPresent was permanently false and the 'View installed Operators' link was never shown.

Additionally the link URL used /k8s/ns/all-namespaces/ instead of /k8s/all-namespaces/, causing 'No Operators found' on navigation.

Fix: remove both the ClusterOperator and CSV watches. Both navigation links are now always shown when the alert renders — correct since the alert only mounts when Upgradeable=False is already confirmed on ClusterVersion. Use resourceListPathFromModel() for the correct all-namespaces URL.

Backport note: On release-4.21 the ClusterNotUpgradeableAlert lives in cluster-settings.tsx (not cluster-settings-utils.tsx as in main) and uses SyncMarkdownView/removeQueryArgument (not MarkdownView/useQueryParamsMutator) due to refactoring between 4.21 and main. The fix is otherwise identical. Test fixtures updated for stricter UpdateHistory/ClusterVersionStatus types on 4.21, and jest.mock factories use React.createElement instead of JSX (older babel-plugin-jest-hoist constraint).

https://issues.redhat.com/browse/OCPBUGS-113468

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rsacherer · 2026-08-25T12:23:44Z

/jira refresh

openshift-ci-robot · 2026-08-25T12:23:48Z

@rsacherer: This pull request references Jira Issue OCPBUGS-113468, which is invalid:

expected Jira Issue OCPBUGS-113468 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rsacherer · 2026-08-25T15:32:26Z

/jira refresh

openshift-ci-robot · 2026-08-25T15:32:30Z

@rsacherer: This pull request references Jira Issue OCPBUGS-113468, which is invalid:

expected Jira Issue OCPBUGS-113468 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rsacherer · 2026-08-25T15:33:19Z

/jira refresh

openshift-ci-robot · 2026-08-25T15:33:22Z

@rsacherer: This pull request references Jira Issue OCPBUGS-113468, which is invalid:

expected Jira Issue OCPBUGS-113468 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rsacherer · 2026-08-25T15:35:42Z

/jira refresh

openshift-ci-robot · 2026-08-25T15:35:48Z

@rsacherer: This pull request references Jira Issue OCPBUGS-113468, which is invalid:

expected Jira Issue OCPBUGS-113468 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rsacherer · 2026-08-25T15:42:36Z

/jira refresh

openshift-ci-robot · 2026-08-25T15:42:44Z

@rsacherer: This pull request references Jira Issue OCPBUGS-113468, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.z) matches configured target version for branch (4.21.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-109521 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-109521 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Leo6Leo · 2026-08-25T15:44:43Z

/ok-to-test
/pipeline required

openshift-merge-bot · 2026-08-25T15:44:46Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-gcp-console

openshift-ci · 2026-08-25T22:04:20Z

@rsacherer: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jhadvig

/lgtm
/approve
/label backport-risk-assessed

openshift-merge-bot · 2026-08-26T10:40:36Z

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

openshift-ci · 2026-08-26T10:40:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, rsacherer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [jhadvig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 24, 2026

openshift-ci Bot requested review from rhamilto and sg00dwin August 24, 2026 12:18

openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 24, 2026

openshift-ci Bot added the component/core Related to console core functionality label Aug 24, 2026

rsacherer force-pushed the OCPBUGS-109521-remove-csv-watch-4.21 branch from 001118f to 8da6e00 Compare August 24, 2026 12:24

rsacherer changed the title ~~OCPBUGS-113467: Remove unscoped CSV watch from ClusterNotUpgradeableAlert~~ OCPBUGS-113468: Remove unscoped CSV watch from ClusterNotUpgradeableAlert Aug 24, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 25, 2026

openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 25, 2026

jhadvig changed the title ~~OCPBUGS-113468: Remove unscoped CSV watch from ClusterNotUpgradeableAlert~~ [release-4.21] OCPBUGS-113468: Remove unscoped CSV watch from ClusterNotUpgradeableAlert Aug 26, 2026

jhadvig approved these changes Aug 26, 2026

View reviewed changes

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 26, 2026

openshift-ci Bot assigned jhadvig Aug 26, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2026

Uh oh!

Conversation

rsacherer commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-merge-bot Bot commented Aug 24, 2026

Uh oh!

openshift-ci-robot commented Aug 24, 2026

Uh oh!

coderabbitai Bot commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci Bot commented Aug 24, 2026

Uh oh!

rsacherer commented Aug 24, 2026

Uh oh!

openshift-ci-robot commented Aug 24, 2026

Uh oh!

openshift-ci-robot commented Aug 24, 2026

Uh oh!

rsacherer commented Aug 25, 2026

Uh oh!

openshift-ci-robot commented Aug 25, 2026

Uh oh!

rsacherer commented Aug 25, 2026

Uh oh!

openshift-ci-robot commented Aug 25, 2026

Uh oh!

rsacherer commented Aug 25, 2026

Uh oh!

openshift-ci-robot commented Aug 25, 2026

Uh oh!

rsacherer commented Aug 25, 2026

Uh oh!

openshift-ci-robot commented Aug 25, 2026

Uh oh!

rsacherer commented Aug 25, 2026

Uh oh!

openshift-ci-robot commented Aug 25, 2026

Uh oh!

Leo6Leo commented Aug 25, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 25, 2026

Uh oh!

openshift-ci Bot commented Aug 25, 2026

Uh oh!

jhadvig left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-merge-bot Bot commented Aug 26, 2026

Uh oh!

openshift-ci Bot commented Aug 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rsacherer commented Aug 24, 2026 •

edited

Loading

coderabbitai Bot commented Aug 24, 2026 •

edited

Loading