Skip to content

[release-4.22] OCPBUGS-114725: display operators in catalog when Tech Preview enabled - #17103

Open
sdodson wants to merge 2 commits into
release-4.22from
cherry-pick-16976-to-release-4.22
Open

[release-4.22] OCPBUGS-114725: display operators in catalog when Tech Preview enabled#17103
sdodson wants to merge 2 commits into
release-4.22from
cherry-pick-16976-to-release-4.22

Conversation

@sdodson

@sdodson sdodson commented Aug 27, 2026

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #16976

Backports OLMv1 catalog fix commits to release-4.22:

  • fix(olm-v1): correct inverted loaded/loading semantics in catalog hooks
  • fix(olm): disable OLMv0 operator item-type when OLMv1 is enabled

Note: The Playwright test commit (9906290) was skipped due to conflicts — those test files were removed in the 4.22 branch.

simkam and others added 2 commits August 27, 2026 15:08
@simkam @claude @sdodson
fix(olm-v1): correct inverted loaded/loading semantics in catalog hooks
3076bb6 
useCatalogItems returned `loading = true` (in progress) as the second
element of its tuple, but CatalogExtensionHookResolver treats the second
element as `loaded = true` (ready). This caused the catalog to call
onValueResolved immediately with an empty array, then never again once
real items arrived from /api/olm/catalog-items/.

Rename `loading` to `loaded` and invert the initial state (false → true
on completion) in both useCatalogItems and useCatalogCategories.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@simkam @claude @sdodson
fix(olm): disable OLMv0 operator item-type when OLMv1 is enabled
9aca69e 
The OLMv0 console.catalog/item-type for "operator" had no flag guard,
causing it to remain active alongside the OLMv1 item-type when
OLMV1_ENABLED=true. This produced a duplicate "Operators" entry in the
catalog type selector.

Add the same disallowed: [OLMV1_ENABLED] flag that already gates the
OLMv0 item-provider, so only the OLMv1 item-type is active when OLMv1
is enabled.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@openshift-merge-bot

openshift-merge-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci
openshift-ci Bot requested review from Leo6Leo and cajieh August 27, 2026 19:14
@openshift-ci openshift-ci Bot added the component/olm Related to OLM label Aug 27, 2026
@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sdodson
Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson

sdodson commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

/assign @simkam

@openshift-ci-robot

openshift-ci-robot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

@sdodson: Jira Issue OCPBUGS-85646 has been cloned as Jira Issue OCPBUGS-114725. Will retitle bug to link to clone.
/retitle [release-4.22] OCPBUGS-114388: display operators in catalog when Tech Preview enabled

Details

In response to this:

This is an automated cherry-pick of #16976

Backports OLMv1 catalog fix commits to release-4.22:

  • fix(olm-v1): correct inverted loaded/loading semantics in catalog hooks
  • fix(olm): disable OLMv0 operator item-type when OLMv1 is enabled

Note: The Playwright test commit (9906290) was skipped due to conflicts — those test files were removed in the 4.22 branch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sdodson

sdodson commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

/retitle [release-4.22] OCPBUGS-114388: display operators in catalog when Tech Preview enabled

@sdodson

sdodson commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

/retitle [release-4.22] OCPBUGS-114725: display operators in catalog when Tech Preview enabled

@openshift-ci openshift-ci Bot changed the title [release-4.22] OCPBUGS-114388: display operators in catalog when Tech Preview enabled [release-4.22] OCPBUGS-114725: display operators in catalog when Tech Preview enabled Aug 27, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 27, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

@sdodson: This pull request references Jira Issue OCPBUGS-114725, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #16976

Backports OLMv1 catalog fix commits to release-4.22:

  • fix(olm-v1): correct inverted loaded/loading semantics in catalog hooks
  • fix(olm): disable OLMv0 operator item-type when OLMv1 is enabled

Note: The Playwright test commit (9906290) was skipped due to conflicts — those test files were removed in the 4.22 branch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

@sdodson: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/frontend 9aca69e link true /test frontend

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cajieh cajieh Awaiting requested review from cajieh
@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees

@simkam simkam

Labels

component/olm Related to OLM jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sdodson @openshift-ci-robot @simkam