OCPBUGS-119240: gcp: allow GCD load balancer health-check firewall ranges

[patrickdillon]

GCD regions have unique source IP addresses for load-balancer health probes that are distinct from GCP. So for GCD installs we need to populate the source based on the region/soverign data center. These ranges cannot be determined programmatically (e.g. via API), so they must be hard-coded. With this approach, unforunately, any new region will need to be manually updated; although, BYO firewall rules can be used until that time.

Additionally, cloud-provider-gcp creates service-type LoadBalancer health-check firewall rules using the public GCP ranges, which GCD rejects, and it cannot be configured with the correct ranges. So this commit pre-creates a rule with the correct ranges, covering both externalTrafficPolicy=Cluster (10256) and =Local (the dynamic healthCheckNodePort range). While this opens a wide range of ports the source is tightly scoped to a well-known IP.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2146eef3-2dc5-4a9c-bf1f-5529a89035eb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[patrickdillon]

/jira cherrypick OCPBUGS-119104

[openshift-ci-robot]

@patrickdillon: Jira Issue OCPBUGS-119104 has been cloned as Jira Issue OCPBUGS-119240. Will retitle bug to link to clone.
/retitle OCPBUGS-119240: gcp: allow GCD load balancer health-check firewall ranges

Details

In response to this:

/jira cherrypick OCPBUGS-119104

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@patrickdillon: This pull request references Jira Issue OCPBUGS-119240, which is invalid:

• expected dependent Jira Issue OCPBUGS-119104 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

GCD regions have unique source IP addresses for load-balancer health probes that are distinct from GCP. So for GCD installs we need to populate the source based on the region/soverign data center. These ranges cannot be determined programmatically (e.g. via API), so they must be hard-coded. With this approach, unforunately, any new region will need to be manually updated; although, BYO firewall rules can be used until that time.

Additionally, cloud-provider-gcp creates service-type LoadBalancer health-check firewall rules using the public GCP ranges, which GCD rejects, and it cannot be configured with the correct ranges. So this commit pre-creates a rule with the correct ranges, covering both externalTrafficPolicy=Cluster (10256) and =Local (the dynamic healthCheckNodePort range). While this opens a wide range of ports the source is tightly scoped to a well-known IP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[patrickdillon]

/testwith openshift/installer/release-4.22/e2e-gcd-ovn-private-techpreview openshift/cloud-provider-gcp#141 openshift/machine-api-provider-gcp#193 openshift/image-registry#476 openshift/gcp-pd-csi-driver#129 openshift/cloud-credential-operator#1083 openshift/cluster-image-registry-operator#1364 openshift/cluster-ingress-operator#1564 openshift/cloud-network-config-controller#264

[openshift-ci]

@patrickdillon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/gcp-custom-endpoints-proxy-wif	7bc2a94	link	false	/test gcp-custom-endpoints-proxy-wif

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[patrickdillon]

/testwith openshift/installer/release-4.22/e2e-gcd-ovn-private-techpreview openshift/cloud-provider-gcp#141 openshift/machine-api-provider-gcp#193 openshift/image-registry#476 openshift/gcp-pd-csi-driver#129 openshift/cloud-credential-operator#1083 openshift/cluster-image-registry-operator#1364 openshift/cluster-ingress-operator#1564 openshift/cloud-network-config-controller#264

[patrickdillon]

multi-pr test failed to start due to a collision. this is a problem with the test setup code. openning a bug

[patrickdillon]

/testwith openshift/installer/release-4.22/e2e-gcd-ovn-private-techpreview openshift/cloud-provider-gcp#141 openshift/machine-api-provider-gcp#193 openshift/image-registry#476 openshift/gcp-pd-csi-driver#129 openshift/cloud-credential-operator#1083 openshift/cluster-image-registry-operator#1364 openshift/cluster-ingress-operator#1564 openshift/cloud-network-config-controller#264

[tthvo]

/lgtm
/approve

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-gcp-custom-dns
/test e2e-gcp-custom-endpoints
/test e2e-gcp-default-config
/test e2e-gcp-ovn
/test e2e-gcp-ovn-byo-vpc
/test e2e-gcp-ovn-xpn
/test e2e-gcp-secureboot
/test e2e-gcp-xpn-custom-dns
/test e2e-gcp-xpn-dedicated-dns-project
/test e2e-aws-ovn

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tthvo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/infrastructure/gcp/OWNERS [tthvo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment