fix: stop configure-pages from injecting Nuxt 2 config properties#85
Open
ronnyabuto wants to merge 1 commit intoopensource254:masterfrom
Open
fix: stop configure-pages from injecting Nuxt 2 config properties#85ronnyabuto wants to merge 1 commit intoopensource254:masterfrom
ronnyabuto wants to merge 1 commit intoopensource254:masterfrom
Conversation
actions/configure-pages with static_site_generator: nuxt injects router.base and target: static into nuxt.config.js. Both are Nuxt 2 options that no longer exist in Nuxt 3. The action's config parser throws a bare string when it can't resolve the injection, which causes TypeError: error must be an instance of Error and the build never reaches nuxt generate. Removing static_site_generator: nuxt stops the injection entirely. Also adds public/.nojekyll so GitHub Pages doesn't hide _nuxt/ assets. Closes opensource254#78
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/configure-pages with static_site_generator: nuxt injects router.base and target: static into nuxt.config.js. Both are Nuxt 2 options that no longer exist in Nuxt 3. The action's config parser throws a bare string when it can't resolve the injection, which causes TypeError: error must be an instance of Error and the build never reaches nuxt generate.
Removing static_site_generator: nuxt stops the injection entirely. Also adds public/.nojekyll so GitHub Pages doesn't hide _nuxt/ assets.
Closes #78