Implement messaging bus configuration with migration from deprecated fields #1779
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lmiccini The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b2a3d439c8814f05b0c2f08b6a6b9c6f ❌ openstack-k8s-operators-content-provider FAILURE in 9m 59s |
lmiccini
force-pushed
the
webhooks_warnings
branch
from
450896d to
b09a3e9
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fd5125ae7eae429eb2db4f62c0e41a23 ❌ openstack-k8s-operators-content-provider FAILURE in 11m 05s |
lmiccini
force-pushed
the
webhooks_warnings
branch
from
b09a3e9 to
d03a9e4
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d13d58737b3f4498b4dc077f36386426 ❌ openstack-k8s-operators-content-provider FAILURE in 11m 31s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/90c60faaaf2e4fa595f8933e7d902af6 ❌ openstack-k8s-operators-content-provider FAILURE in 11m 58s |
lmiccini
force-pushed
the
webhooks_warnings
branch
from
d03a9e4 to
c7710b0
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2a422293faf3401fac04ac4bd2890857 ❌ openstack-k8s-operators-content-provider FAILURE in 12m 02s |
lmiccini
force-pushed
the
webhooks_warnings
branch
from
c7710b0 to
1cba828
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c5f4ffdd2be54836ab44b9be351f31bd ❌ openstack-k8s-operators-content-provider FAILURE in 12m 01s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/29b6f20f660d422b9634779c551f90fc ❌ openstack-k8s-operators-content-provider FAILURE in 12m 41s |
lmiccini
force-pushed
the
webhooks_warnings
branch
from
2d1b5de to
92d8fcf
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9f5e717422684715af6bc5ce7aa28a29 ❌ openstack-k8s-operators-content-provider FAILURE in 11m 17s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a2d1b61a202e43ae8cf4d5aa21c8ab88 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 02m 41s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a446018498ca49a28aa3bd563a195361 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 56m 50s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7ff33f99c93a49d497ba272bc24c0c28 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 04m 25s |
|
recheck |
lmiccini
force-pushed
the
webhooks_warnings
branch
from
228d3f7 to
4aa0f88
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5126af01b24749c986440666e01ba238 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 20m 40s |
|
recheck |
|
/test openstack-operator-build-deploy-kuttl |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/92eabbd78f094f04b8833087acdc5fc3 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 23m 30s |
|
recheck |
lmiccini
force-pushed
the
webhooks_warnings
branch
2 times, most recently
from
1ee039b to
16ba3f9
Compare
|
/test openstack-operator-build-deploy-kuttl |
lmiccini
force-pushed
the
webhooks_warnings
branch
3 times, most recently
from
4ed90c4 to
3989d1e
Compare
|
/test openstack-operator-build-deploy-kuttl |
lmiccini
force-pushed
the
webhooks_warnings
branch
from
c109bbf to
4492578
Compare
|
/test functional |
lmiccini
force-pushed
the
webhooks_warnings
branch
2 times, most recently
from
27b903f to
66dc5cf
Compare
lmiccini
changed the title
lmiccini
force-pushed
the
webhooks_warnings
branch
from
66dc5cf to
340bdb8
Compare
…fields Add top-level MessagingBus and NotificationsBus configuration to OpenstackControlPlane API to replace service-specific RabbitMQ settings. This provides a centralized way to configure messaging infrastructure while maintaining backward compatibility. API changes: - Add MessagingBus field for RPC communication configuration (username, vhost, cluster) - Add NotificationsBus field for notifications configuration - Deprecate NotificationsBusInstance in favor of NotificationsBus.Cluster - Remove default values for deprecated rabbitMqClusterName fields across all service CRDs to enable proper migration Webhook changes: - Update ValidateCreate and ValidateUpdate to return warnings in addition to errors - Add centralized validation for deprecated fields with warning messages - Add ValidateMessagingBusConfig validation - Update service validation calls to capture warnings from downstream operators Controller changes: - Add migration logic to automatically populate NotificationsBus.Cluster from deprecated NotificationsBusInstance field during reconciliation - Migration occurs before service reconciliation to ensure services inherit migrated values Service integration: - Update all service templates (barbican, cinder, designate, glance, heat, ironic, keystone, manila, neutron, nova, octavia, swift, telemetry, watcher) to support new messaging bus fields - Services inherit top-level configuration but can override with service-specific settings Testing: - Add comprehensive migration tests for deprecated field handling - Add RabbitMQ cascading configuration tests - Update functional tests for new configuration structure Additional fixes: - Fix pin-bundle-images.sh to handle operators with replace directives by forcing quay.io for replaced operators and adding fallback logic when bundles are not available in custom registries Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
lmiccini
force-pushed
the
webhooks_warnings
branch
from
340bdb8 to
d0bba95
Compare
|
/test functional |
|
@lmiccini: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Add top-level MessagingBus and NotificationsBus configuration to
OpenstackControlPlane API to replace service-specific RabbitMQ settings.
This provides a centralized way to configure messaging infrastructure
while maintaining backward compatibility.
API changes:
vhost, cluster)
all service CRDs to enable proper migration
Webhook changes:
to errors
operators
Controller changes:
from deprecated NotificationsBusInstance field during reconciliation
inherit migrated values
Service integration:
heat, ironic, keystone, manila, neutron, nova, octavia, swift,
telemetry, watcher) to support new messaging bus fields
service-specific settings
Testing:
Additional fixes:
by forcing quay.io for replaced operators and adding fallback logic
when bundles are not available in custom registries
Co-Authored-By: Claude Sonnet 4.5 [email protected]
Depends-on: openstack-k8s-operators/data-plane-adoption#1222