feat: add CancelProxy type for time-delayed proxy announcements#2402
Open
thecaptain789 wants to merge 1 commit intoopentensor:mainfrom
Open
feat: add CancelProxy type for time-delayed proxy announcements#2402thecaptain789 wants to merge 1 commit intoopentensor:mainfrom
thecaptain789 wants to merge 1 commit intoopentensor:mainfrom
Conversation
This PR adds a new proxy type that enables users to delegate the ability to reject proxy announcements without granting other permissions. This is particularly useful for time-delayed proxies where: - Users want to be able to cancel pending announcements for security - They don't want to grant broader permissions to the delegate - The Cancel proxy can ONLY call from the proxy pallet Implements the feature request from issue opentensor#590. Changes: - Added CancelProxy variant to ProxyType enum - Added TryFrom/From implementations (value: 18) - Added InstanceFilter implementation allowing only reject_announcement calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
CancelProxyproxy type that enables users to delegate the ability to reject proxy announcements without granting other permissions.Closes #590
Motivation
When using time-delayed proxies, users need the ability to:
The
CancelProxytype addresses this by only allowingreject_announcementcalls from the proxy pallet.Changes
common/src/lib.rs
CancelProxyvariant toProxyTypeenumruntime/src/lib.rs
reject_announcementcallsUsage
Users can now add a proxy with the
CancelProxytype to delegate the ability to reject pending announcements:Testing
The existing mock implementations use catch-all patterns and will handle the new variant correctly.