Skip to content

Add Spring web operation name handler#139

Open
zouyx wants to merge 3 commits into
opentracing-contrib:masterfrom
zouyx:addHandlerName
Open

Add Spring web operation name handler#139
zouyx wants to merge 3 commits into
opentracing-contrib:masterfrom
zouyx:addHandlerName

Conversation

@zouyx

@zouyx zouyx commented Dec 14, 2020

Copy link
Copy Markdown

1.Support Spring RequestMapping
2.HandlerUtils.requestMapping,if use .path()can not get anything when use @Requestmapping
so change to value()

@geoand

geoand commented Dec 14, 2020

Copy link
Copy Markdown
Collaborator

Hi,

Thanks for the contribution.

Can you please explain the rationale behind these changes?

@zouyx

zouyx commented Dec 15, 2020

Copy link
Copy Markdown
Author

Hi,

Thanks for the contribution.

Can you please explain the rationale behind these changes?

Relate to #115 which can not run travis CI.

Just recreate it.

@geoand

geoand commented Dec 15, 2020

Copy link
Copy Markdown
Collaborator

I see thanks.

Could you please add a test as was requested in the original PR?

@zouyx

zouyx commented Dec 15, 2020

Copy link
Copy Markdown
Author

I see thanks.

Could you please add a test as was requested in the original PR?

I think will add it in this few day

@zeitlinger

Copy link
Copy Markdown

@zouyx not sure I understand this PR correctly. Is this about changing the operation name to be something more meaningful than GET?

@zouyx

zouyx commented Apr 17, 2021

Copy link
Copy Markdown
Author

@zouyx not sure I understand this PR correctly. Is this about changing the operation name to be something more meaningful than GET?

yes, you are right. because it can not get anything when use @RequestMapping

@zeitlinger

Copy link
Copy Markdown

Fixes #143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants