Merge develop into infrahub-develop#934
Open
infrahub-github-bot-app[bot] wants to merge 4 commits intoinfrahub-developfrom
Open
Merge develop into infrahub-develop#934infrahub-github-bot-app[bot] wants to merge 4 commits intoinfrahub-developfrom
infrahub-github-bot-app[bot] wants to merge 4 commits intoinfrahub-developfrom
Conversation
* Draft overview page sdk * refresh sdk overview * spelling * Add product context * Apply suggestion from @BaptisteGi
The get, create, update, and delete commands were registered at the root of infrahubctl, which felt out of place next to unrelated top-level commands like check, render, and transform. They naturally belong under `infrahubctl object` alongside load and validate, since they all operate on Infrahub objects. Tests updated accordingly.
github-actions
bot
added
the
type/documentation
Deploying infrahub-sdk-python with
|
| Latest commit: |
729e8ef
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://390dbb79.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://develop.infrahub-sdk-python.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## infrahub-develop #934 +/- ##
====================================================
+ Coverage 82.56% 82.63% +0.07%
====================================================
Files 134 133 -1
Lines 13194 13250 +56
Branches 2287 2306 +19
====================================================
+ Hits 10893 10949 +56
Misses 1652 1652
Partials 649 649
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Merge stable into develop
The CRUD command files (create, delete, get, update) and their shared utilities lived in a generic "commands" directory that didn't convey what they were for. Since they all belong to the "infrahubctl object" subgroup, it makes sense to colocate them as an "object" package. Test files follow the same restructuring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging develop into infrahub-develop after merging pull request #931.