AlwaysHalt tag on call to breakpoint built-in in BytecodeDSL interp#662
Open
OctaveLarose wants to merge 1 commit intooracle:masterfrom
Open
AlwaysHalt tag on call to breakpoint built-in in BytecodeDSL interp#662OctaveLarose wants to merge 1 commit intooracle:masterfrom
OctaveLarose wants to merge 1 commit intooracle:masterfrom
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
msimacek
reviewed
Mar 3, 2026
Contributor
msimacek
left a comment
msimacek
left a comment
There was a problem hiding this comment.
Looks good. There's a bit of a difference that it would trigger even if you do just breakpoint and don't call it, but I guess it's fine, it's an approximation anyway. Do you think you could add a test for it in PythonDebugTest?
| } else if (uses.contains(DefUse.GlobalImplicit)) { | ||
| if (scope.isFunction()) { | ||
| emitNameGlobalOperation(mangled, op, b, true); | ||
| if (mangled.equals(J_BREAKPOINT)) { |
Contributor
There was a problem hiding this comment.
What if it's not in in a function scope?
Contributor
Author
There was a problem hiding this comment.
That was me mirroring the original code which only emits a global op if within a function scope. But frankly, I don't understand why that is the case.
Should breakpoint be an exception to the rule and call emitNameGlobalOperation even if we're outside of a function?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allowing debugging with
--inspectto break on calls tobreakpointin the BytecodeDSL interpreter