Added support for sorting an array of objects using myObject.sortKey#36
Open
laurenceks wants to merge 1 commit intooverset:masterfrom
Open
Added support for sorting an array of objects using myObject.sortKey#36laurenceks wants to merge 1 commit intooverset:masterfrom
laurenceks wants to merge 1 commit intooverset:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tweaked two lines in naturalSort.js so that it will look for a key called ".sortKey" and use that as a comparison value before falling back to comparing a/b itself. This allows an array of objects to be sorted by setting the object's .sortKey key to whatever value you want to sort without affecting original behaviour.