Set default expiration date if none given on share creation#22646
Merged
DeepDiver1975 merged 1 commit intomasterfrom Feb 26, 2016
Merged
Set default expiration date if none given on share creation#22646DeepDiver1975 merged 1 commit intomasterfrom
DeepDiver1975 merged 1 commit intomasterfrom
Conversation
When we create a share for the first time we should set the default expiration date. If none is given. Fixes #22642
Contributor
|
I can't reproduce the original issue from the web UI, probably because the order of calls is different ? The code makes sense. |
Contributor
|
Tested, works 👍 Here is the command to share a folder "test": |
|
please add "expireDate" to the "Create a new Share" API-function |
Contributor
Contributor
|
Tested and works 👍 |
DeepDiver1975
added a commit
that referenced
this pull request
Feb 26, 2016
Set default expiration date if none given on share creation
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we create a share for the first time we should set the default
expiration date. If none is given.
This used to be the case. But I think I did it wrong when I reused it for updateShare as well.
Now there is a unit test for this.
Fixes #22642
@SergioBertolinSG is it possible to have intergration tests that test this part of the sharing API as well (so with the config stuff changing)?
@javiergonzper please verify this fixes it.
CC: @PVince81 @schiesbn @nickvergessen @MorrisJobke