Repository navigation
Make it harder to forget to submit targets/filters subform #2627
Description
@iliana reports (and I think @charliepark have discussed this before) that it feels like the firewall rules form is just ignoring your target because you typed it in but forgot to click Add Target. There is probably something we can do about this. It's probably too much to refuse to submit the overall form if there's unsubmitted stuff in the target or filter field, but we can probably warn the user somehow.
Activity
charliepark commentedon Jan 3, 2025
I'm not totally against disabling the form if there's stray data. "You have an unsaved {target|host} filter; save or clear it to create this firewall rule."
david-crespo commentedon Jan 3, 2025
Yeah, on second thought it’s rare enough that it doesn’t feel like too much friction.
david-crespo commentedon Aug 4, 2025
As noted in #2634 (comment), we are hoping to fix this by eliminating the subforms and making the minitable editable directly instead. That PR (which doesn't exist yet) can close this issue.
charliepark commentedon Aug 25, 2025
#2878 is the PR for minitable editing. Adding it so the various dashboards showing linked PRs can 🤞 auto update.