Add filters to IP pool list endpoint (#9147)#10278
Open
ijsnow wants to merge 1 commit into
Open
Conversation
… endpoint (oxidecomputer#9147) Introduces a new API version (2026-04-15) adding optional `ip_version` and `delegated_for_internal_use` query parameters to the `/v1/system/ip-pools` endpoint, allowing server-side filtering of pools by IP version and whether they are delegated for internal Oxide use.
ijsnow
force-pushed
the
api-ip-pool-list-filters
branch
from
5346725 to
8c3f7ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new API version (2026-04-15) adding optional
ip_versionanddelegated_for_internal_usequery parameters to the/v1/system/ip-poolsendpoint, allowing server-side filtering of pools by IP version and whether they are delegated for internal Oxide use.The changes and tests were based off a previous PR that was closed by the author. Issues with serde(flatten) made it so the scanner pattern wasn't possible with
Option<bool>, so separate params were added. This meant I needed to modify the http_testing utility to pass parameters that don't end up encoded with the pagination parameters into the next page. All other tests still pass with this change.I used the /add-api-version skill since this would modify blessed openapi spec versions even though this is a strictly additive PR with defaults that would result in the same exact functionality.