[illumos-utils][zfs] Only set properties if they change#10666
Open
smklein wants to merge 3 commits into
Open
Conversation
…e as none Addresses two issues in the skip-if-unchanged property reconciliation: - set_values_if_changed previously fell back to setting all properties (including quota) when it could not read the current ones. That reintroduced the failure mode this change set out to fix (re-applying a quota when used has crept past it). A read failure or a dataset missing from the results now propagates instead. - render_size now renders a zero quota/reservation as "none", matching how ZFS persists and reports it, so a desired zero converges against the persisted value instead of being re-set on every reconcile.
jgallagher
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZFS, in certain circumstances, can allow write traffic to the filesystem permitting
used > quota.When this happens, a call to
zfs set quota, with any value overused, will fail - even if thezfs setcall ismerely trying to set the quota to the existing value.
To mitigate, this PR modifies our mechanism for setting ZFS properties: we supply existing properties, and only
try to
zfs setvalues which have actually changed.Fixes #10662