Skip to content

fix(async search): don't launch intervals in goroutines - #506

Merged
forshev merged 1 commit into
mainfrom
0-fix-async-search-parallelism
Sep 2, 2026
Merged

fix(async search): don't launch intervals in goroutines#506
forshev merged 1 commit into
mainfrom
0-fix-async-search-parallelism

Conversation

@forshev

@forshev forshev commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Description

Don't launch intervals in goroutines when doing async search.


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

@codecov-commenter

codecov-commenter commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.53%. Comparing base (94e5bd0) to head (6be1b9d).

Files with missing lines Patch % Lines
asyncsearcher/async_searcher.go 20.00% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
- Coverage   71.56%   71.53%   -0.03%     
==========================================
  Files         239      239              
  Lines       20158    20150       -8     
==========================================
- Hits        14426    14415      -11     
  Misses       4652     4652              
- Partials     1080     1083       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@forshev
forshev force-pushed the 0-fix-async-search-parallelism branch from be94a81 to 6be1b9d Compare September 1, 2026 14:30
@eguguchkin eguguchkin added this to the v0.78.0 milestone Sep 1, 2026
@eguguchkin
eguguchkin requested a review from cheb0 September 1, 2026 23:07
@forshev
forshev merged commit 74b1103 into main Sep 2, 2026
8 checks passed
@forshev
forshev deleted the 0-fix-async-search-parallelism branch September 2, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants