perf: do not tie field lifetime to buffer lifetime - #507
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
==========================================
- Coverage 71.37% 71.20% -0.17%
==========================================
Files 250 250
Lines 21709 21711 +2
==========================================
- Hits 15494 15459 -35
- Misses 5063 5088 +25
- Partials 1152 1164 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dkharms
marked this pull request as ready for review
September 2, 2026 12:05
eguguchkin
approved these changes
Sep 4, 2026
forshev
approved these changes
Sep 4, 2026
dkharms
force-pushed
the
0-release-token-lids-buf
branch
from
September 4, 2026 16:46
01154c4 to
5593ba8
Compare
Contributor
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
dkharms
force-pushed
the
0-release-token-lids-buf
branch
from
September 4, 2026 18:09
5593ba8 to
b60ba98
Compare
Contributor
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
tokenLIDsWorkerwe allocate continuous buffer for storing non-existing (yet) tokens (field:valuepairs) and later we use some chunks of this buffer as keys inFieldTIDshashmap -- so we prolongate lifetime of the whole buffer.If you have used LLM/AI assistance please provide model name and full prompt: