Skip to content

perf: do not tie field lifetime to buffer lifetime - #507

Merged
dkharms merged 1 commit into
mainfrom
0-release-token-lids-buf
Sep 4, 2026
Merged

perf: do not tie field lifetime to buffer lifetime#507
dkharms merged 1 commit into
mainfrom
0-release-token-lids-buf

Conversation

@dkharms

@dkharms dkharms commented Sep 2, 2026

Copy link
Copy Markdown
Member

Description

In tokenLIDsWorker we allocate continuous buffer for storing non-existing (yet) tokens (field:value pairs) and later we use some chunks of this buffer as keys in FieldTIDs hashmap -- so we prolongate lifetime of the whole buffer.


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

@codecov-commenter

codecov-commenter commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.20%. Comparing base (560903e) to head (b60ba98).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
- Coverage   71.37%   71.20%   -0.17%     
==========================================
  Files         250      250              
  Lines       21709    21711       +2     
==========================================
- Hits        15494    15459      -35     
- Misses       5063     5088      +25     
- Partials     1152     1164      +12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dkharms
dkharms marked this pull request as ready for review September 2, 2026 12:05
@dkharms dkharms added the performance Features or improvements that positively affect seq-db performance label Sep 2, 2026
@eguguchkin
eguguchkin requested a review from forshev September 4, 2026 13:16
@dkharms
dkharms force-pushed the 0-release-token-lids-buf branch from 01154c4 to 5593ba8 Compare September 4, 2026 16:46
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
ProcessDocuments-4 e37ed3 9272e5
567.00 B/op 13086.00 B/op 23.08 🔴

@dkharms
dkharms force-pushed the 0-release-token-lids-buf branch from 5593ba8 to b60ba98 Compare September 4, 2026 18:09
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
MutexListAppend-4 560903 6fa32d
188.06 MB/s 167.06 MB/s 0.89 🔴

@dkharms
dkharms merged commit cde9a46 into main Sep 4, 2026
8 checks passed
@dkharms
dkharms deleted the 0-release-token-lids-buf branch September 4, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Features or improvements that positively affect seq-db performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants