Skip to content

fix: pass correct readers for legacy sealed fraction - #508

Closed
dkharms wants to merge 1 commit into
mainfrom
0-fix-sealed-source
Closed

fix: pass correct readers for legacy sealed fraction#508
dkharms wants to merge 1 commit into
mainfrom
0-fix-sealed-source

Conversation

@dkharms

@dkharms dkharms commented Sep 2, 2026

Copy link
Copy Markdown
Member

Description

When trying to compact legacy fractions following panic occurs:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0xbb4a17]

goroutine 173 [running]:
github.com/ozontech/seq-db/storage.(*ReaderProvider).GetReader(0x0)
    github.com/ozontech/seq-db/storage/index_reader.go:37 +0x57
github.com/ozontech/seq-db/frac.(*Sealed).mustGetReader(0xc0002a68c0, 0x1602a01?)
    github.com/ozontech/seq-db/frac/sealed.go:283 +0x51
github.com/ozontech/seq-db/frac.NewSealedSource(0xc0002a68c0)
    github.com/ozontech/seq-db/frac/sealed_source.go:34 +0x57
github.com/ozontech/seq-db/compaction.(*Executor).compact(0xc0004a6280, {{0x0, 0xee1e04ee0, 0x2395120}, {0xc000115038, 0x6}, {0xc000244090, 0x27}, 0xc0006e83c0, 0xc0004c0600})
    github.com/ozontech/seq-db/compaction/executor.go:60 +0x2ea
github.com/ozontech/seq-db/compaction.NewExecutor.(*Executor).init.func1()
    github.com/ozontech/seq-db/compaction/executor.go:41 +0x145
sync.(*WaitGroup).Go.func1()
    sync/waitgroup.go:239 +0x4a
created by sync.(*WaitGroup).Go in goroutine 1
    sync/waitgroup.go:237 +0x73

  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.55%. Comparing base (94e5bd0) to head (b1d6051).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
frac/sealed_source.go 57.14% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
- Coverage   71.56%   71.55%   -0.02%     
==========================================
  Files         239      239              
  Lines       20158    20161       +3     
==========================================
  Hits        14426    14426              
- Misses       4652     4653       +1     
- Partials     1080     1082       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eguguchkin eguguchkin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve this, but I think it would be better to merge this same fix as part of another PR

@dkharms

dkharms commented Sep 4, 2026

Copy link
Copy Markdown
Member Author

Will be fixed in #489

@dkharms dkharms closed this Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants