Skip to content

Warn for CYRILLIC, unknown#58

Open
thinkyhead wants to merge 4 commits intop3p:masterfrom
thinkyhead:pr_misc_fixups_for_2_nov
Open

Warn for CYRILLIC, unknown#58
thinkyhead wants to merge 4 commits intop3p:masterfrom
thinkyhead:pr_misc_fixups_for_2_nov

Conversation

@thinkyhead
Copy link
Copy Markdown
Contributor

Allow builds not using HD44780 that happen to have weird DISPLAY_CHARSET_HD44780 values to pass.

Also suppress deprecated sprintf warnings to use snprintf that should instead be warning us to use Rust.

@thinkyhead thinkyhead force-pushed the pr_misc_fixups_for_2_nov branch 2 times, most recently from ed5e729 to 4a1e87b Compare November 2, 2025 09:14
@p3p
Copy link
Copy Markdown
Owner

p3p commented Dec 1, 2025

I don't mind cosmetic PRs, although some of the changes I don't agree with, but not merged with real fixes putting off rebasing this to remove them is what has delayed merging ^^

@thinkyhead thinkyhead force-pushed the pr_misc_fixups_for_2_nov branch from 4a1e87b to 129c8a7 Compare March 25, 2026 23:37
@thinkyhead
Copy link
Copy Markdown
Contributor Author

Well, what I do with my projects is to cherry-pick the pieces I like from a PR, trying to preserve author information in the final result. One simple way to get there is to do a git diff HEAD master | git apply to revert all changes without any commit, then construct a commit with only selected changes reverted, the rest left as-is. Sometimes I do a bit of extra labor to make sure nothing is missed. I don't like to push this stuff back on the contributor because it's usually just faster to do it myself and get it exactly right in one go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants