Reduce blast-radius of UNSET in default_map#3240
Open
kdeldycke wants to merge 5 commits intopallets:stablefrom
Open
Reduce blast-radius of UNSET in default_map#3240kdeldycke wants to merge 5 commits intopallets:stablefrom
UNSET in default_map#3240kdeldycke wants to merge 5 commits intopallets:stablefrom
Conversation
kdeldycke
changed the title
UNSET in default_mapUNSET in default_map
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reproduce the case pointed out at #3224 (comment) , as we have no coverage of the effect of UNSET in
default_map.The problem is that default management is spread across
lookup_default,get_defaultandconsume_value, so we need to make all them bullet-proof else they all leaks into each other because they evaluateUNSETas a truthy value. To make the code somewhat manageable, I added a private_default_map_hasutility method whose role is to be the single source of truth.So this PR is somewhat a follow-up on #3224, where we had to make the evaluation in
lookup_defaultmore complex to hideUNSETto fix #3145.