-
-
Notifications
You must be signed in to change notification settings - Fork 19.5k
API/CoW: take view of underlying Block values for shallow (deep=False) copies #58966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jorisvandenbossche
wants to merge
8
commits into
pandas-dev:main
Choose a base branch
from
jorisvandenbossche:cow-shallow-copy-values-view
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
68af237
API/CoW: take view of underlying Block values for shallow (deep=False…
jorisvandenbossche e45e423
use self instead of shallow copy for inplace operations
jorisvandenbossche 93c1f5f
Merge remote-tracking branch 'upstream/main' into cow-shallow-copy-va…
jorisvandenbossche a880e7e
update tests
jorisvandenbossche 110a3e8
fix replace case
jorisvandenbossche 8ad9435
fix replace keep ref to self for inplace
jorisvandenbossche 553fa12
Merge remote-tracking branch 'upstream/main' into cow-shallow-copy-va…
jorisvandenbossche 52649b6
fix typing
jorisvandenbossche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,7 +35,7 @@ def __init__(self, data, dtype) -> None: | |
| self._dtype = dtype | ||
|
|
||
| def __array__(self, dtype=None, copy=None): | ||
| return self.data | ||
| return np.asarray(self.data, dtype=dtype) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this change just to honor the dtype keyword (in which case we should probably honor copy too?)? or is it important that we not return the object self.data? if the latter, is that a requirement for EAs that should be added to the interface tests? |
||
|
|
||
| @property | ||
| def dtype(self): | ||
|
|
@@ -50,6 +50,9 @@ def __getitem__(self, item): | |
| def copy(self): | ||
| return self | ||
|
|
||
| def view(self): | ||
| return self | ||
|
|
||
|
|
||
| class TestSelectDtypes: | ||
| def test_select_dtypes_include_using_list_like(self, using_infer_string): | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the actual change (taking a view of the values when doing a shallow copy), the other changes below in this file are a few fixes to ensure we return
selfinstead of a shallow copy forinplaceoperations.