Skip to content

PERF: avoid fallback in dt.total_seconds for Arrow durations #63422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fangchenli wants to merge 6 commits into
base: main
Choose a base branch
from
+3 −1
Open

PERF: avoid fallback in dt.total_seconds for Arrow durations #63422

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f9fa158
PERF: use PyArrow-native implementation for dt.total_seconds
fangchenli Dec 19, 2025
f20b03d
CLN: combine nested casts in _dt_total_seconds
fangchenli Dec 19, 2025
138cdf8
CLN: remove unnecessary float64 cast in _dt_total_seconds
fangchenli Dec 19, 2025
4936e7d
Merge remote-tracking branch 'upstream' into perf/dt-total-seconds-ar…
fangchenli Dec 19, 2025
f7b8299
use divide instead of multiply
fangchenli Dec 19, 2025
ea827f7
change factor to float
fangchenli Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pandas/core/arrays/arrow/array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2917,7 +2917,9 @@ def _dt_to_pytimedelta(self) -> np.ndarray:
return np.array(data, dtype=object)

def _dt_total_seconds(self) -> Self:
result = pa.array(self._to_timedeltaarray().total_seconds(), from_pandas=True)
unit = self._pa_array.type.unit
unit_per_second = {"s": 1.0, "ms": 1e3, "us": 1e6, "ns": 1e9}
result = pc.divide(pc.cast(self._pa_array, pa.int64()), unit_per_second[unit])
return self._from_pyarrow_array(result)

def _dt_as_unit(self, unit: str) -> Self:
Expand Down
Loading