fix: GraphQL error messages disclose required input field names when public introspection is disabled (GHSA-2fgh-8j2g-w354)#10567
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
📝 WalkthroughWalkthroughGraphQL error sanitization now redacts schema identifiers from additional coercion messages and stack traces when public introspection is disabled. Tests cover restricted callers, master-key access, public introspection, and inline-literal validation. ChangesGraphQL error redaction
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (2 errors, 1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/GraphQL/ParseGraphQLServer.js`:
- Around line 73-83: Extend stripSchemaCoercionIdentifiers to redact the type
and field identifiers in the “Expected type "<type>" to be an object.” and
“Field "<field>" is not defined by type "<type>".” coercion messages, while
preserving their non-sensitive wording. Add regression tests covering malformed
nested values and unknown nested fields, verifying generated schema/type names
are absent from the resulting errors.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 70d47f1d-a383-4538-9db7-ed65c0c7c709
📒 Files selected for processing (2)
spec/ParseGraphQLServer.spec.jssrc/GraphQL/ParseGraphQLServer.js
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.x.x #10567 +/- ##
=================================================
+ Coverage 92.47% 92.49% +0.01%
=================================================
Files 192 192
Lines 16190 16194 +4
Branches 234 234
=================================================
+ Hits 14972 14978 +6
+ Misses 1198 1196 -2
Partials 20 20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@coderabbitai review your feedback conversations and resolve where you found a consensus |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="parse-community/parse-server"
pr=10567
echo "=== Review comments (threaded) ==="
gh api repos/$repo/pulls/$pr/comments --paginate \
--jq '.[] | {id, in_reply_to_id, user: .user.login, path, line, body: .body[0:300], diff_hunk: .diff_hunk[0:200]}'Length of output: 2534 🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="parse-community/parse-server"
pr=10567
gh api graphql -f query='
query($owner:String!, $name:String!, $pr:Int!) {
repository(owner:$owner, name:$name) {
pullRequest(number:$pr) {
reviewThreads(first:50) {
nodes {
id
isResolved
comments(first:10) {
nodes { id databaseId author { login } body }
}
}
}
}
}
}' -f owner=parse-community -f name=parse-server -F pr=$pr \
--jq '.data.repository.pullRequest.reviewThreads.nodes[] | {id, isResolved, comment_ids: [.comments.nodes[].databaseId]}'Length of output: 854
That thread ( |
mtrezza
changed the title
mtrezza
merged commit 6985a38
into
parse-community:release-8.x.x
## [8.6.86](8.6.85...8.6.86) (2026-07-10) ### Bug Fixes * GraphQL error messages disclose required input field names when public introspection is disabled ([GHSA-2fgh-8j2g-w354](GHSA-2fgh-8j2g-w354)) ([#10567](#10567)) ([6985a38](6985a38)), closes [GHSA-2f#8j2g-w354](https://github.com/GHSA-2f/issues/8j2g-w354) [/github.com/parse-community/parse-server/security/advisories/GHSA-2f#8j2g-w354](https://github.com//github.com/parse-community/parse-server/security/advisories/GHSA-2f/issues/8j2g-w354)
|
🎉 This change has been released in version 8.6.86 |
2 participants
Issue
GraphQL error messages disclose required input field names when public introspection is disabled (GHSA-2fgh-8j2g-w354)
Tasks