Skip to content

chore(overrides): Try removing Puppeteer overrides#884

Merged
rebeccaalpert merged 3 commits into
patternfly:mainfrom
rebeccaalpert:overrides
Jul 22, 2026
Merged

chore(overrides): Try removing Puppeteer overrides#884
rebeccaalpert merged 3 commits into
patternfly:mainfrom
rebeccaalpert:overrides

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jul 21, 2026

Copy link
Copy Markdown
Member

We introduced the Puppeteer change to be targeted to the workspace in #825 since CI had started failing. We wanted to see if removing the overrides would let us back it out.

CI now seems to run and I can do screenshots with PUPPETEER_EXECUTABLE_PATH="/Applications/Google Chrome.app/Contents/MacOS/Google Chrome" npm run docs:screenshots.

Opening follow-up #885 for the screenshots having different background colors.

@patternfly-build

patternfly-build commented Jul 21, 2026

Copy link
Copy Markdown

@rebeccaalpert
rebeccaalpert marked this pull request as ready for review July 22, 2026 13:48
@rebeccaalpert
rebeccaalpert merged commit 60f081c into patternfly:main Jul 22, 2026
6 checks passed
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 6.8.0-prerelease.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants