Skip to content

fix(jump-links): landmark label #2870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bennypowers wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(jump-links): landmark label #2870

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
017052e
fix(jump-links): landmark label
bennypowers Oct 27, 2024
17abdfc
fix(jump-links): add default label
bennypowers Nov 5, 2024
27cbcf1
fix(jump-links): update default label
adamjohnson Nov 5, 2024
a8397ef
feat(jump-links): add part to label
adamjohnson Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changeset/grumpy-lemons-like.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
"@patternfly/elements": patch
---
`<pf-jump-links>`: improve screen reader accessibility by labeling the navigation landmark element
2 changes: 1 addition & 1 deletion elements/pf-jump-links/pf-jump-links.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export class PfJumpLinks extends LitElement {

render(): TemplateResult<1> {
return html`
<nav id="container">${this.expandable ? html`
<nav id="container" aria-labelledby="label">${this.expandable ? html`
<details ?open="${this.expanded}" @toggle="${this.#onToggle}">
<summary>
<pf-icon icon="chevron-right"></pf-icon>
Expand Down