feat!: rename all elements to pf-v5-* prefix#3088
Open
bennypowers wants to merge 32 commits intostaging/pfe5from
Open
feat!: rename all elements to pf-v5-* prefix#3088bennypowers wants to merge 32 commits intostaging/pfe5from
bennypowers wants to merge 32 commits intostaging/pfe5from
Conversation
Rename all 35 elements and their sub-components from pf-* to pf-v5-*. CSS custom properties renamed from --pf-c-* to --pf-v5-c-*. Global tokens (--pf-global--*) are unchanged. Closes #3052, closes #3053, closes #3054, closes #3055, closes #3056, closes #3057, closes #3058, closes #3059, closes #3060, closes #3061, closes #3062, closes #3063, closes #3064, closes #3065, closes #3066, closes #3067, closes #3068, closes #3069, closes #3070, closes #3071, closes #3072, closes #3073, closes #3074, closes #3075, closes #3076, closes #3077, closes #3078, closes #3079, closes #3080, closes #3081, closes #3082, closes #3083, closes #3084, closes #3085, closes #3086 Assisted-By: Claude Opus 4.6 (1M context) <[email protected]>
🦋 Changeset detectedLatest commit: cbe3bd0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
* fix(table): fix accessibility audit failures - Correct ARIA role for column headers (`colheader` -> `columnheader`) - Add accessible label to the row expand/collapse toggle button - Add `aria-controls` linking the toggle button to its expansion content Closes #2813 Assisted-By: Claude Opus 4.6 (1M context) <[email protected]> * docs: changeset Fix accessibility features for the pf-table component, including column header role and accessible label for the row toggle button. --------- Co-authored-by: Benny Powers <[email protected]> Co-authored-by: Benny Powers <[email protected]>
Contributor
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "feat!: rename all elements to pf-v5-* prefix"
} |
Contributor
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
Closes #2499 Assisted-By: Claude Opus 4.6 (1M context) <[email protected]>
…shed package (#2970) Closes #2967 Assisted-By: Claude Opus 4.6 (1M context) <[email protected]>
Exclude build outputs (.js, .d.ts, .js.map) from the esbuild tsconfig so TypeScript doesn't try to overwrite them. Closes #2712 Assisted-By: Claude Opus 4.6 (1M context) <[email protected]>
Closes #2967 Assisted-By: Claude Opus 4.6 (1M context) <[email protected]>
* fix(back-to-top): change background color on hover and focus Apply hover/focus colors directly rather than through CSS custom property overrides that don't cascade into shadow DOM. Closes #2743 Assisted-By: Claude Opus 4.6 (1M context) <[email protected]> * docs: changeset
Add fallback in getSlotted() to query slot elements directly when async slot record initialization hasn't completed yet. Closes #2946 Assisted-By: Claude Opus 4.6 (1M context) <[email protected]>
* perf(tabs): add passive scroll event listeners Closes #2600 Assisted-By: Claude Opus 4.6 (1M context) <[email protected]> * docs: changeset
* fix(select): replace RH color tokens with PF v4 global tokens Closes #2954 Assisted-By: Claude Opus 4.6 (1M context) <[email protected]> * docs: changeset
Closes #2771 Assisted-By: Claude Opus 4.6 (1M context) <[email protected]>
…#3101) * fix(popover): outsideClick should not fire on already-hidden popovers Guard the outsideClick handler to skip popovers that are already hidden, preventing spurious hide/hidden events on closed popovers when clicking anywhere on the page. Closes #2513 Assisted-By: Claude Opus 4.6 (1M context) <[email protected]> * docs: changeset
Match PFv4 link label behavior: on hover/focus the border thickens to 2px and changes to the primary color. Labels keep their normal background and border styling. Assisted-By: Claude Opus 4.6 (1M context) <[email protected]>
* fix(jump-links): landmark label Closes #2860 * fix(jump-links): add default label * fix(jump-links): update default label * feat(jump-links): add part to label --------- Co-authored-by: Adam Johnson <[email protected]>
* fix(switch): add static accessible label Rename `label` property to `accessibleLabel` (attribute: `accessible-label`) for consistency. Wire it to set `ariaLabel` on element internals for a proper static accessible name. Closes #2754 Assisted-By: Claude Opus 4.6 (1M context) <[email protected]> * docs: changeset * fix(switch): keep label as deprecated, add accessible-label Keep the existing `label` property as deprecated and fall back to it when `accessible-label` is not set. JSDoc advises updating the accessible label based on checked state. Assisted-By: Claude Opus 4.6 (1M context) <[email protected]>
Use #container:has(#link:hover) instead of :host(:hover) so the border only thickens when hovering the link text itself, not when hovering the close button. Matches PFv4 behavior. Assisted-By: Claude Opus 4.6 (1M context) <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…3105) * docs: adding LGTM tradition to README and storing full list of LGTMs in root of repo * docs: adding README updates * docs: lgtms --------- Co-authored-by: Benny Powers <[email protected]>
Update all docs site references to use the new pf-v5-* element names, including HTML tags, CSS selectors, import paths, and code examples. Blog posts and changelogs left unchanged as historical records. PF4 core CSS tokens (--pf-c-content/title/text) left unchanged as they reference the PF CSS framework, not pf-elements components. Assisted-By: Claude Opus 4.6 (1M context) <[email protected]>
Contributor
- Update main.mjs to import PfV5Icon from renamed path - Update pfe-assets.cjs regex and JSDoc for pf-v5-* paths - Pass prefix option to PfeAssetsPlugin in eleventy config - Replace broken generateImportMap shortcodes with static import maps (jspm.io can't resolve unpublished pf-v5-* paths) - Fix pre-existing TS build errors: use Router.Middleware instead of non-existent RouterMiddleware export, remove stale @ts-expect-error directive - Fix pre-existing slug function call using deprecated eleventyConfig.javascript.functions API Assisted-By: Claude Opus 4.6 (1M context) <[email protected]>
- Use koa Middleware type instead of Router.Middleware namespace (namespace not available with Node moduleResolution) - Use @ts-ignore instead of @ts-expect-error for colorjs.io import (error occurs on CI but not locally due to moduleResolution) Assisted-By: Claude Opus 4.6 (1M context) <[email protected]>
Apply pf-v5-* rename rules to all incoming changes from main: - label: link variant, hover borders, icon colors, link.html demo - switch: accessible-label property and tests - popover: outsideClick guard for hidden popovers - table: columnheader role fix, toggle button a11y - tabs: passive scroll event listeners - jump-links: landmark label with part attribute - select: replace rh-color tokens with pf-global tokens - back-to-top: hover/focus background color, pf-button selectors - core: SlotController fix Assisted-By: Claude Opus 4.6 (1M context) <[email protected]>
`@sindresorhus/slugify` v2 is ESM-only. Node 22 `require()` of ESM returns the module namespace object, not the default export, causing `TypeError: slugify is not a function` in the eleventy `ids` transform. Assisted-By: Claude Sonnet 4.6 (1M context) <[email protected]>
Contributor
- README: update test path examples to pf-v5-* element dirs - elements/package.json: remove orphaned pf-jazz-hands export entry - eslint.config.js: fix pf-icon ignore path to pf-v5-icon - bundle.ts: update pf-icon export to pf-v5-icon - dev server index.html template: update pf-button/pf-icon/pf-card tags and imports to pf-v5-* equivalents - docs/_snippets: update accordion-jsx and card-html import paths - vue.md: fix CodeSandbox search hint to @patternfly/elements Assisted-By: Claude Sonnet 4.6 (1M context) <[email protected]>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename all 35 elements and their sub-components from
pf-*topf-v5-*:<pf-button>becomes<pf-v5-button>--pf-c-button--*becomes--pf-v5-c-button--*PfButtonbecomesPfV5Button--pf-global--*) are unchangedElements renamed
pf-accordion, pf-alert, pf-avatar, pf-back-to-top, pf-background-image,
pf-badge, pf-banner, pf-button, pf-card, pf-chip, pf-clipboard-copy,
pf-code-block, pf-dropdown, pf-helper-text, pf-hint, pf-icon,
pf-jump-links, pf-label, pf-label-group, pf-modal, pf-panel, pf-popover,
pf-progress, pf-progress-stepper, pf-search-input, pf-select, pf-spinner,
pf-switch, pf-table, pf-tabs, pf-text-area, pf-text-input, pf-tile,
pf-timestamp, pf-tooltip
Closes #3052, #3053, #3054, #3055, #3056, #3057, #3058, #3059,
#3060, #3061, #3062, #3063, #3064, #3065, #3066, #3067,
#3068, #3069, #3070, #3071, #3072, #3073, #3074, #3075,
#3076, #3077, #3078, #3079, #3080, #3081, #3082, #3083,
#3084, #3085, #3086
Test plan