fix(ui): prevent stale upload docs from overwriting value - #17735
Open
ertugakmann wants to merge 1 commit into
Open
fix(ui): prevent stale upload docs from overwriting value#17735ertugakmann wants to merge 1 commit into
ertugakmann wants to merge 1 commit into
Conversation
ertugakmann
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
August 10, 2026 10:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes a race condition in the Upload field where an older
populateDocs()request can overwrite the state of a newer field value.Why?
When upload values change while a previous
populateDocs()request is still in flight, the older request can resolve later and replacepopulatedDocswith stale data.This can cause upload values to disappear, particularly in
hasManyupload fields inside Lexical blocks.How?
Track the latest field
valuewith a ref and only applypopulateDocs()results if they still match the current value.Added a regression test covering out-of-order requests and a test for the normal in-order case.
Fixes #17731