refactor!: improve access defaults for jobs - #17768
Open
AlessioGr wants to merge 2 commits into
Open
Conversation
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
AlessioGr
commented
Aug 12, 2026
| } | ||
|
|
||
| const accessFn = jobsConfig.access?.run ?? (() => true) | ||
| const accessFn = jobsConfig.access?.run ?? defaultAccess |
Member
Author
There was a problem hiding this comment.
Just a better default. Won't matter much in reality, as jobsConfig.access?.run is only fals-y if the user explicitly passes undefined or null.
Without configuration, jobsConfig.access?.run gets a default value during sanitization
AlessioGr
commented
Aug 12, 2026
|
|
||
| try { | ||
| const { totalDocs } = await payload.count({ | ||
| const { totalDocs } = await payload.db.count({ |
Member
Author
There was a problem hiding this comment.
This is an internal lookup for a document the user already has permission to publish. The previous access check using overrideAccess: false was pointless
AlessioGr
marked this pull request as ready for review
August 12, 2026 20:31
AlessioGr
enabled auto-merge (squash)
August 12, 2026 20:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generic create, read, update, and delete access on
payload-jobsis now disabled by default.The Jobs documentation now explains the difference between dedicated Jobs APIs and raw collection CRUD.
Why?
Job documents are internal system data, so generic collection access should be opt-in. Dedicated APIs such as
payload.jobs.*,/run, and/handle-schedulesremain the recommended ways to work with jobs.Projects that intentionally expose the jobs collection can still configure its access through
jobsCollectionOverrides.Breaking changes
Projects that use REST or GraphQL CRUD directly on
payload-jobs, or Local API CRUD withoverrideAccess: false, will now be denied by default. The dedicatedpayload.jobs.*APIs and trusted Local API calls with access override enabled continue to work as before.If your project intentionally exposes job documents, add the required collection access through
jobsCollectionOverrides. Prefer read-only access for trusted administrators because job documents can contain sensitive information.