Skip to content

feat: add new postgres minor release images#272

Merged
moizpgedge merged 1 commit intomainfrom
Feat/PLAT-432/Update-Postgres-images-in-Control-Plane-for-new-PG-minor-versions
Feb 19, 2026
Merged

feat: add new postgres minor release images#272
moizpgedge merged 1 commit intomainfrom
Feat/PLAT-432/Update-Postgres-images-in-Control-Plane-for-new-PG-minor-versions

Conversation

@moizpgedge
Copy link
Contributor

@moizpgedge moizpgedge commented Feb 19, 2026

Summary

Adds support for new Postgres minor release images (16.12, 17.8, 18.2) from pgEdge/postgres-images and sets the default Control Plane image to 18.2.

Changes

  • server/internal/orchestrator/swarm/images.go: Added image mappings for Postgres 16.12, 17.8, and 18.2 (Spock 5.0.5, standard flavor, tags *-spock5.0.5-standard-1). Set default version to 18.2.
  • e2e/minor_version_upgrade_test.go: Updated minor upgrade test to use 18.1 → 18.2 so it exercises the latest supported upgrade path.

Testing

  • make test (unit tests) — passed.
  • make test-e2e E2E_FIXTURE=lima E2E_DEBUG=1 (full E2E on small Lima fixture) — all 45 tests passed, including:
    • TestCreateDbWithVersions for all 10 versions (16.10–18.2).
    • TestMinorVersionUpgrade (18.1 → 18.2).
    • Remaining E2E tests (backup/restore, failover/switchover, MCP, etc.).

Checklist

  • Tests added or updated (unit and/or e2e, as needed)
  • Documentation updated (if needed)
  • Issue is linked (branch name or URL in PR description)
  • Changelog entry added for user-facing behavior changes
  • Breaking changes (if any) are clearly called out in the PR description

Notes for Reviewers

@moizpgedge moizpgedge requested a review from mmols February 19, 2026 18:11
@coderabbitai
Copy link

coderabbitai bot commented Feb 19, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

This PR updates the default PostgreSQL PgEdge version to 18.2, adds PgEdgeVersion entries for 16.12, 17.8, and 18.2 with corresponding image tags, and adjusts the end-to-end test to validate a minor upgrade path from 18.1 to 18.2.

Changes

Cohort / File(s) Summary
Test Update
e2e/minor_version_upgrade_test.go
Changes the minor-version upgrade test path from 18.0→18.1 to 18.1→18.2; test logic and assertions remain unchanged.
Version Registry Update
server/internal/orchestrator/swarm/images.go
Adds PgEdgeVersion entries for 16.12 (spock5.0.5), 17.8 (spock5.0.5), and 18.2 (spock5.0.5); updates defaultVersion from 18.1 to 18.2.

Poem

🐇 I nibble code in moonlit view,
From 18.1 we hop to 18.2,
New versions sown, images stacked,
Tests retread the upgrade track,
A rabbit’s cheer for builds anew! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding new Postgres minor release images, which is exactly what the PR does.
Description check ✅ Passed The description includes all key template sections (Summary, Changes, Testing, Checklist) with substantial detail. The Summary explains what was added, Changes lists the modified files with specifics, and Testing documents comprehensive test results.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch Feat/PLAT-432/Update-Postgres-images-in-Control-Plane-for-new-PG-minor-versions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
e2e/minor_version_upgrade_test.go (1)

17-129: Consider adding upgrade-path coverage for PG16 and PG17 across the Spock epoch boundary.

The 18.1 → 18.2 upgrade crosses the spock5.0.4 → spock5.0.5 boundary, and so do 16.11 → 16.12 and 17.7 → 17.8. The existing TestCreateDbWithVersions validates image reachability for new versions but not the in-place minor upgrade flow. A parametrized upgrade test (or two additional sub-tests) would confirm the upgrade path is clean for all three PG major versions on the new Spock epoch.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@e2e/minor_version_upgrade_test.go` around lines 17 - 129, The test
TestMinorVersionUpgrade only covers an 18.1→18.2 minor bump; add parametrized
sub-tests (or separate sub-tests) to exercise the same in-place minor-upgrade
flow for PG16 and PG17 across the Spock epoch boundary (e.g., 16.11→16.12 and
17.7→17.8). Update TestMinorVersionUpgrade to iterate over a table of cases with
fields like name, fromVersion, toVersion and run the existing
create/validate/update/validate sequence using those variables (reuse
functions/variables in the test such as fromVersion/toVersion, db.Update,
db.WithConnection, and asserts on primary/updated instances) so each case
asserts the primary remains the same and the server_version changes to the
target.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@e2e/minor_version_upgrade_test.go`:
- Around line 17-129: The test TestMinorVersionUpgrade only covers an 18.1→18.2
minor bump; add parametrized sub-tests (or separate sub-tests) to exercise the
same in-place minor-upgrade flow for PG16 and PG17 across the Spock epoch
boundary (e.g., 16.11→16.12 and 17.7→17.8). Update TestMinorVersionUpgrade to
iterate over a table of cases with fields like name, fromVersion, toVersion and
run the existing create/validate/update/validate sequence using those variables
(reuse functions/variables in the test such as fromVersion/toVersion, db.Update,
db.WithConnection, and asserts on primary/updated instances) so each case
asserts the primary remains the same and the server_version changes to the
target.

@moizpgedge moizpgedge changed the title Plat-432:-Minor version updated feat: add new postgres minor release images Feb 19, 2026
@moizpgedge moizpgedge force-pushed the Feat/PLAT-432/Update-Postgres-images-in-Control-Plane-for-new-PG-minor-versions branch from 832f059 to dac4159 Compare February 19, 2026 21:32
@moizpgedge moizpgedge merged commit ca1a915 into main Feb 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants