feat: add new postgres minor release images#272
Conversation
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughThis PR updates the default PostgreSQL PgEdge version to 18.2, adds PgEdgeVersion entries for 16.12, 17.8, and 18.2 with corresponding image tags, and adjusts the end-to-end test to validate a minor upgrade path from 18.1 to 18.2. Changes
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
e2e/minor_version_upgrade_test.go (1)
17-129: Consider adding upgrade-path coverage for PG16 and PG17 across the Spock epoch boundary.The
18.1 → 18.2upgrade crosses thespock5.0.4 → spock5.0.5boundary, and so do16.11 → 16.12and17.7 → 17.8. The existingTestCreateDbWithVersionsvalidates image reachability for new versions but not the in-place minor upgrade flow. A parametrized upgrade test (or two additional sub-tests) would confirm the upgrade path is clean for all three PG major versions on the new Spock epoch.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@e2e/minor_version_upgrade_test.go` around lines 17 - 129, The test TestMinorVersionUpgrade only covers an 18.1→18.2 minor bump; add parametrized sub-tests (or separate sub-tests) to exercise the same in-place minor-upgrade flow for PG16 and PG17 across the Spock epoch boundary (e.g., 16.11→16.12 and 17.7→17.8). Update TestMinorVersionUpgrade to iterate over a table of cases with fields like name, fromVersion, toVersion and run the existing create/validate/update/validate sequence using those variables (reuse functions/variables in the test such as fromVersion/toVersion, db.Update, db.WithConnection, and asserts on primary/updated instances) so each case asserts the primary remains the same and the server_version changes to the target.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@e2e/minor_version_upgrade_test.go`:
- Around line 17-129: The test TestMinorVersionUpgrade only covers an 18.1→18.2
minor bump; add parametrized sub-tests (or separate sub-tests) to exercise the
same in-place minor-upgrade flow for PG16 and PG17 across the Spock epoch
boundary (e.g., 16.11→16.12 and 17.7→17.8). Update TestMinorVersionUpgrade to
iterate over a table of cases with fields like name, fromVersion, toVersion and
run the existing create/validate/update/validate sequence using those variables
(reuse functions/variables in the test such as fromVersion/toVersion, db.Update,
db.WithConnection, and asserts on primary/updated instances) so each case
asserts the primary remains the same and the server_version changes to the
target.
832f059 to
dac4159
Compare
Summary
Adds support for new Postgres minor release images (16.12, 17.8, 18.2) from pgEdge/postgres-images and sets the default Control Plane image to 18.2.
Changes
server/internal/orchestrator/swarm/images.go: Added image mappings for Postgres 16.12, 17.8, and 18.2 (Spock 5.0.5, standard flavor, tags*-spock5.0.5-standard-1). Set default version to 18.2.e2e/minor_version_upgrade_test.go: Updated minor upgrade test to use 18.1 → 18.2 so it exercises the latest supported upgrade path.Testing
make test(unit tests) — passed.make test-e2e E2E_FIXTURE=lima E2E_DEBUG=1(full E2E on small Lima fixture) — all 45 tests passed, including:TestCreateDbWithVersionsfor all 10 versions (16.10–18.2).TestMinorVersionUpgrade(18.1 → 18.2).Checklist
Notes for Reviewers
https://pgedge.atlassian.net/browse/PLAT-432?atlOrigin=eyJpIjoiOTQ4YjgyMjIxYmVlNDY5ZmJlZjM3ZTExMjkyZGJjMGUiLCJwIjoiaiJ9