[kundansable]

Problem

In the Statistics Create dialog, selecting a column immediately cleared the selection, so columns could not be chosen.

Cause

The columns field's depChange also fires on the field's own changes, so every selection reset columns to [].

Fix

Reset the columns only when the schema or table field changes.

Testing

Manually in the UI: picked table t, selected columns a and b; both stayed selected and Save became enabled.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Changing the selected columns no longer clears the selection unexpectedly.
  • Changing the schema or table still clears the column selection to reflect the updated context.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pgadmin-org/pgadmin4
• Branch: master
• File: .coderabbit.yaml
• Commit: 062099a
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 4a826987-3538-4598-bbed-17de7a407395

Commits

Reviewing files that changed from the base of the PR and between 93217e9 and 9b57399.

Files selected for processing: 1

• web/regression/javascript/schema_ui_files/statistics.ui.spec.js

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

Walkthrough

The columns dependency-change handler now clears the selection only when the change source is schema or table. A regression test covers changes to columns, schema, and table.

Changes

Statistics column selection

Layer / File(s)	Summary
Conditional column selection clearing web/pgadmin/browser/server_groups/servers/databases/schemas/statistics/static/js/statistics.ui.js, web/regression/javascript/schema_ui_files/statistics.ui.spec.js	The handler clears columns only when the change source is schema or table. The regression test checks that changing columns itself does not clear its value and that schema or table changes clear it.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: asheshv

Merge Risk: Minimal · up to 9b573

The Statistics column-selection fix is covered by the regression test and is mergeable.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly describes the main change: preventing the Statistics dialog from clearing the columns selection when a column is selected. The issue reference is acceptable.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files.

Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

🟢 Approval recommended

The narrow guard addresses the selection bug while preserving context resets; the optional regression-test suggestion is non-blocking.

1 open issue

• Add regression tests for depChange selection reset behavior · New

What changed in this PR

Fixes column selection in the Statistics Create dialog by limiting selection resets to changes in the table context.

Changes:

• Preserves selected columns when the columns field changes.
• Continues clearing columns when the schema or table changes.
• Adds comments explaining why the callback ignores its own field changes.

File	Description
web/​pgadmin/​browser/​server_groups/​servers/​databases/​schemas/​statistics/​static/​js/​statistics.ui.js	Guards the column-reset callback by the changed field.

_{Review effort: Balanced}