Handle Android releases without pending changelog entries - #80
Merged
Conversation
The informational modal test assumed that every branch had unreleased changelog fragments. This failed immediately after preparing an Android release, when the preview heading was correctly absent. Keep the modal assertion concerned with the rendered changelog and test the no-fragment behavior explicitly in the controlled changelog fixture.
Stable tagging previously failed when there was no Web-only Preview to consolidate. Warn before changing any files and require an explicit y response before preparing an empty release. Empty releases update the Android and F-Droid version metadata without adding empty NEWS or Fastlane changelog entries.
|
Preview for dc00fc4: It can take a minute or two after this comment appears for |
pganssle
pushed a commit
to pganssle/cim-previews
that referenced
this pull request
Aug 3, 2026
pganssle
pushed a commit
to pganssle/cim-previews
that referenced
this pull request
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modal test assumed that every build would have a
Web-only Previewsection. That is not true immediately after preparing an Android release, so the test failed onmaineven though the rendered changelog was correct. This keeps the modal test independent of the current fragment state and explicitly checks in the controlled changelog fixture that no preview is generated when there are no fragments.The Android tag script also no longer treats an empty changelog as an unconditional error. It warns and prompts with a default of
Nbefore changing anything. If confirmed withy, it updates the version metadata and creates the tag without adding an empty NEWS section or F-Droid changelog file.Tests:
./tests/test_tag_android_version.shmake testThe full run passed 100 Playwright tests with 2 expected skips, as well as the F-Droid metadata check and Android emulator smoke test.