docs: migrate.md adjust volume mount path#2337
Merged
alexandre-daubois merged 3 commits intophp:mainfrom Apr 23, 2026
Merged
Conversation
Signed-off-by: Francis Lavoie <[email protected]>
Contributor
|
Oh, great catch, but the image defaults to /app. We'll need to adjust all other occurrences instead :/ |
henderkes
pushed a commit
to henderkes/frankenphp
that referenced
this pull request
Apr 10, 2026
The FrankenPHP Docker image defaults to /app, so update all Caddyfile examples to use /app/public instead of /var/www/app/public. The "Before" (Nginx/PHP-FPM) examples retain /var/www/app as that reflects a typical legacy setup. Ref: php#2337 https://claude.ai/code/session_01DE6NMaJLcHC5nnQNwwAmCc
Contributor
|
Meh, Claude isn't getting it right. I'll just do it... |
henderkes
approved these changes
Apr 10, 2026
Contributor
henderkes
left a comment
henderkes
left a comment
There was a problem hiding this comment.
The default path isn't /var/www/app for the nginx image either, so it's fine just overwriting the config for our example like we do in the nginx one.
francislavoie
commented
Apr 10, 2026
alexandre-daubois
force-pushed
the
patch-1
branch
from
a89043f to
40f8c65
Compare
Member
|
Thank you @francislavoie! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rest of the examples use
/var/www/app, so the volume mount should match.