fix: don't hang requests dispatched before regular threads are ready - #2612
Merged
henderkes merged 1 commit intoAug 20, 2026
Merged
Conversation
2 tasks
dunglas
approved these changes
Aug 18, 2026
henderkes
approved these changes
Aug 19, 2026
henderkes
left a comment
henderkes
left a comment
Contributor
There was a problem hiding this comment.
Correct, but please don't use walls of LLM text for PR descriptions.
Contributor
Author
Edited with my own words, sorry 🙇♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caddy sometimes starts the HTTP server before FrankenPHP finishes initializing.
A request arriving in that window passes the
isRunningcheck, butregularRequestChanis stillnil, so it blocks forever inhandleRequestWithRegularPHPThreads().Behind a reverse proxy, this shows up as random 499/504 on the first requests after a container starts.
We're now initializing the request channel at declaration so early requests are served anyway once the first thread is started.